python-pyQt5 fixes #22109

fosslinux · 2020-05-19T03:20:58Z

It didn't build for me natively on x86_64 because qmake couldnt find qt5 on the host. Hence, I added it to hostmakedepends. LMK if this is the wrong way to do it and it should be patched out instead.
There is a mv recursive move warning in pre_build that I silenced.
I made xlint happy.

Letting travis run, I only tested x86_64 here.

fosslinux · 2020-05-19T09:56:58Z

Well, since travis timed out, I just attempted a build on x86_64-musl, and it succeed.

Please note that AFAICT the xlint errors are wrong.

sgn · 2020-05-21T11:49:30Z

Please note that AFAICT the xlint errors are wrong.

xlint is correct ;)

fosslinux · 2020-05-21T22:39:19Z

srcpkgs/python-PyQt5/template: Place homepage= after license=

Fixed this.

srcpkgs/python-PyQt5/template:53: indent with tabs

This is cating to a file, it needs to be spaces.

srcpkgs/python-PyQt5/template:7: do not set pycompile_module, it is autodetected
srcpkgs/python-PyQt5/template:100: do not set pycompile_module, it is autodetected
srcpkgs/python-PyQt5/template:117: do not set pycompile_module, it is autodetected
srcpkgs/python-PyQt5/template:283: do not set pycompile_module, it is autodetected

It seems to me that there are a variety of different things that could be compiled in the source tree, I think that the pycompile_modules do need to be there? I sometimes get this wrong, so please do tell me if you are sure that the pycompile_module directives should be removed.

sgn · 2020-05-21T23:11:30Z

On 2020-05-21 15:39:32-0700, fosslinux ***@***.***> wrote: > srcpkgs/python-PyQt5/template:53: indent with tabs This is `cat`ing to a file, it needs to be spaces.

sed -i -e "53,57s/^ //" or even: sed -i -e "53,57s/^ / /" Does it work after that? Sorry but PyQt5 website banned my IP range, it seems like.

> srcpkgs/python-PyQt5/template:7: do not set pycompile_module, it is autodetected > srcpkgs/python-PyQt5/template:100: do not set pycompile_module, it is autodetected > srcpkgs/python-PyQt5/template:117: do not set pycompile_module, it is autodetected > srcpkgs/python-PyQt5/template:283: do not set pycompile_module, it is autodetected It seems to me that there are a variety of different things that could be compiled in the source tree, I think that the `pycompile_module`s do need to be there? I sometimes get this wrong, so please do tell me if you are sure that the pycompile_module directives should be removed.

Yes, it should be removed.

…

-- Danh

fosslinux · 2020-05-22T00:30:49Z

Ok, done, xlint passes without error now. The build also worked.

fosslinux · 2020-05-25T01:09:29Z

@sgn Would you mind reviewing again?

sgn · 2020-05-27T14:37:09Z

My IP is still banned by their host. Sorry, I couldn't test this change.

fosslinux · 2020-05-27T20:50:31Z

Oh, that is quite unfortunate. No pressure, but you could use sources.voidlinux.org, if all that you need to do is get the source code? No problem if you can't though.

Piraty · 2020-07-01T14:49:55Z

please squash those commits into one

fosslinux · 2020-07-21T07:25:20Z

Missed your message. Done

fosslinux · 2020-07-30T09:28:29Z

@Piraty can you review when you have a moment

Piraty

do_install() fails

make: Leaving directory '/builddir/PyQt5-5.13.2/pyqt5-2.7'
mv: cannot stat '/destdir//python-PyQt5-5.13.2/usr/bin//destdir//python-PyQt5-5.13.2/usr/bin/pylupdate5': No such file or directory
=> ERROR: python-PyQt5-5.13.2_2: do_install: 'mv ${DESTDIR}/usr/bin/{,python2-}${f}' exited with 1
=> ERROR:   in do_install() at srcpkgs/python-PyQt5/template:80

fosslinux · 2020-08-03T10:26:23Z

Huh it used to work.

- require qt5 in hostmakedepends, otherwise it errors out with an ugly qmake cannot find qt5 error. - hide 'error' message, which isn't really an error but looks ominous. - fix xlint [ci skip]

fosslinux · 2020-08-05T08:17:44Z

I just rebased and built, WFM. Can you try again.

- require qt5 in hostmakedepends, otherwise it errors out with an ugly qmake cannot find qt5 error. - hide 'error' message, which isn't really an error but looks ominous. - fix xlint [ci skip] Close: void-linux#22109 Co-authored-by: Đoàn Trần Công Danh <congdanhqx@gmail.com>

- require qt5 in hostmakedepends, otherwise it errors out with an ugly qmake cannot find qt5 error. - hide 'error' message, which isn't really an error but looks ominous. - fix xlint Co-authored-by: Đoàn Trần Công Danh <congdanhqx@gmail.com> Close: void-linux#22109

Piraty · 2020-08-11T00:01:33Z

srcpkgs/python-PyQt5/template


 pre_build() {
 	mkdir -p pyqt5-${py2_ver}
-	mv * pyqt5-${py2_ver} || true
+	mv * pyqt5-${py2_ver} 2>/dev/null || true


what is that about? if it fails, why keep it?

It fails because mv: cannot move 'a' to a subdirectory of itself, 'a/a' (something like that).

This command is necessary but the error looks like it fails, even though in fact it doesn't.

It looks like it's trying to move the pyqt5 folder into itself. Could it be filtered from the glob, perhaps? Using find seems like overkill, but should probably work.

This change is endup merged into part of #24182
Actually, I've never like mv * dst || true, create_wrksrc and make a proper tree instead.

create_wrksrc is probably actually the correct way to go.

Would you like me to create a better version that you can rollup into #24182

Anyway, closing this PR

fosslinux · 2020-08-11T06:10:45Z

Superseded by #24182

- require qt5 in hostmakedepends, otherwise it errors out with an ugly qmake cannot find qt5 error. - hide 'error' message, which isn't really an error but looks ominous. - fix xlint Co-authored-by: Đoàn Trần Công Danh <congdanhqx@gmail.com> Close: void-linux#22109

- require qt5 in hostmakedepends, otherwise it errors out with an ugly qmake cannot find qt5 error. - hide 'error' message, which isn't really an error but looks ominous. - fix xlint Co-authored-by: Đoàn Trần Công Danh <congdanhqx@gmail.com> Close: #22109

fosslinux force-pushed the python-pyQt5-makedepends branch from cc92022 to 9964d84 Compare May 21, 2020 22:37

fosslinux force-pushed the python-pyQt5-makedepends branch from 9964d84 to 649674c Compare May 22, 2020 00:30

fosslinux force-pushed the python-pyQt5-makedepends branch from 649674c to 5e98bf7 Compare July 21, 2020 07:25

Piraty requested changes Aug 3, 2020

View reviewed changes

python-pyQt5: various fixes

ac028b7

- require qt5 in hostmakedepends, otherwise it errors out with an ugly qmake cannot find qt5 error. - hide 'error' message, which isn't really an error but looks ominous. - fix xlint [ci skip]

fosslinux force-pushed the python-pyQt5-makedepends branch from 5e98bf7 to ac028b7 Compare August 5, 2020 08:16

sgn mentioned this pull request Aug 10, 2020

PyQt5 5.15.0 #24182

Merged

3 tasks

Piraty requested changes Aug 11, 2020

View reviewed changes

fosslinux closed this Aug 11, 2020

github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

python-pyQt5 fixes #22109

python-pyQt5 fixes #22109

fosslinux commented May 19, 2020 •

edited

Loading

fosslinux commented May 19, 2020 •

edited

Loading

sgn commented May 21, 2020

fosslinux commented May 21, 2020

sgn commented May 21, 2020 via email

fosslinux commented May 22, 2020

fosslinux commented May 25, 2020

sgn commented May 27, 2020

fosslinux commented May 27, 2020

Piraty commented Jul 1, 2020

fosslinux commented Jul 21, 2020

fosslinux commented Jul 30, 2020

Piraty left a comment

fosslinux commented Aug 3, 2020

fosslinux commented Aug 5, 2020

Piraty Aug 11, 2020

fosslinux Aug 11, 2020

ericonr Aug 11, 2020

sgn Aug 11, 2020

fosslinux Aug 11, 2020 •

edited

Loading

fosslinux commented Aug 11, 2020

python-pyQt5 fixes #22109

python-pyQt5 fixes #22109

Conversation

fosslinux commented May 19, 2020 • edited Loading

fosslinux commented May 19, 2020 • edited Loading

sgn commented May 21, 2020

fosslinux commented May 21, 2020

sgn commented May 21, 2020 via email

fosslinux commented May 22, 2020

fosslinux commented May 25, 2020

sgn commented May 27, 2020

fosslinux commented May 27, 2020

Piraty commented Jul 1, 2020

fosslinux commented Jul 21, 2020

fosslinux commented Jul 30, 2020

Piraty left a comment

Choose a reason for hiding this comment

fosslinux commented Aug 3, 2020

fosslinux commented Aug 5, 2020

Piraty Aug 11, 2020

Choose a reason for hiding this comment

fosslinux Aug 11, 2020

Choose a reason for hiding this comment

ericonr Aug 11, 2020

Choose a reason for hiding this comment

sgn Aug 11, 2020

Choose a reason for hiding this comment

fosslinux Aug 11, 2020 • edited Loading

Choose a reason for hiding this comment

fosslinux commented Aug 11, 2020

fosslinux commented May 19, 2020 •

edited

Loading

fosslinux commented May 19, 2020 •

edited

Loading

fosslinux Aug 11, 2020 •

edited

Loading