vpnd: update to 0.1.2.1 #22111
Merged
vpnd: update to 0.1.2.1 #22111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Piraty
requested changes
May 19, 2020
There was a problem hiding this comment.
- you probably want to add the conf file to
conf_files=so users' changes won't get overwritten on update - please don't bloat the install text with information the application provides on its own (i skimmed the source of your script)
- (btw: why not just
ping -c 1 kernel.orgfor 'online check'?)
|
thanks. I'll update accordingly. query for the install text: should I mention breaking changes here (removal of yad as dependency, changes to .conf) at all? or just assume users will check the changelog? |
* 0.1.2.1
- in package
- simplify connectivity check to use ping (+ fixes)
- in template:
- add relevant conf_files field
- in install msgs:
- condense to 2 lines
* 0.1.2
- Breaking changes:
- in vpnd.conf, icons are referenced _without_ the `icon:` prefix in the path
- also new settings introduced
- `yad` removed from dependencies since notification option
introduced (users who want systray icon should (re)install `yad`)
- Improvements:
- optional notifications via notify-send(.sh)
- connectivity check (if ncat/nmap/curl are installed)
- ability to run w/o yad (if no systray is desired) via notify-send(.sh)
- fixes to formatting of `xbps` update output
addressed in 3d6638d
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking changes:
icon:prefix in the pathyadremoved from dependencies since notification optionintroduced (users who want systray icon should (re)install
yad)Improvements:
xbpsupdate output