Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delta: update to 0.1.1 #22317

Merged
merged 1 commit into from May 31, 2020
Merged

delta: update to 0.1.1 #22317

merged 1 commit into from May 31, 2020

Conversation

smorimoto
Copy link
Contributor

No description provided.

@ericonr
Copy link
Member

ericonr commented May 26, 2020

I think you might need to add clang to makedepends.

@ericonr
Copy link
Member

ericonr commented May 26, 2020

Or possibly add oniguruma as a dependency (I wonder if this would work for bat as well).

EDIT: bat already has oniguruma-devel as a dependency, but it's not being used in the build.

@smorimoto
Copy link
Contributor Author

smorimoto commented May 26, 2020

Oh thanks for your pointer.

@ericonr
Copy link
Member

ericonr commented May 26, 2020

Could you take a look at the template for bat? It has some useful info. It does link with oniguruma,
but uses libonig.a instead.

EDIT: no problem c:

@smorimoto smorimoto force-pushed the delta-0.1.1 branch 3 times, most recently from 7361cba to 2ff7c79 Compare May 26, 2020 19:38
@smorimoto
Copy link
Contributor Author

@ericonr Finally, the build passed. Thanks again.

@ericonr
Copy link
Member

ericonr commented May 30, 2020

@imbsky cool! It still required clang and llvm to work?

@smorimoto
Copy link
Contributor Author

Probably yes.

error: failed to run custom build command for `onig_sys v69.2.0`
Caused by:
  process didn't exit successfully: `/builddir/delta-0.1.1/target/release/build/onig_sys-10237aa0f829094d/build-script-build` (exit code: 101)
--- stdout
cargo:warning=couldn't execute `llvm-config --prefix` (error: No such file or directory (os error 2))
cargo:warning=set the LLVM_CONFIG_PATH environment variable to a valid `llvm-config` executable
--- stderr
thread 'main' panicked at 'Unable to find libclang: "couldn\'t find any valid shared libraries matching: [\'libclang.so\', \'libclang-*.so\', \'libclang.so.*\'], set the `LIBCLANG_PATH` environment variable to a path where one of these files can be found (invalid: [])"', /host/cargo/registry/src/github.com-1ecc6299db9ec823/bindgen-0.50.1/src/lib.rs:1711:13
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

@ericonr
Copy link
Member

ericonr commented May 31, 2020

That's weird, but ok. Just wondering why @abenson's version didn't need llvm, only clang. I do think it's best to depend on our own version of oniguruma, which yours does. Thanks for testing c:

@abenson abenson merged commit b7efa32 into void-linux:master May 31, 2020
@smorimoto smorimoto deleted the delta-0.1.1 branch May 31, 2020 17:14
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants