Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NOMERGE] New package: pwntools-4.1.2 #22801

Closed
wants to merge 2 commits into from

Conversation

abenson
Copy link
Contributor

@abenson abenson commented Jun 11, 2020

No description provided.

@Chocimier
Copy link
Member

python3-pwntools installs lot of executables, so should be named pwntools.
python3-ROPgadget advertises as executable, so should be named ROPgadget.

pwntools installs /usr/bin/checksec conflicting with checksec, errno conflicting with moreutils, phd conflicting with disputils.

Executables of pwntools depend on setuptools.

pwntools shouldn't install TESTING.md and more directly into /usr/lib/python3.8/site-packages/.

@abenson
Copy link
Contributor Author

abenson commented Jun 12, 2020

  1. Renamed the packages, that makes sense.
  2. Since the executable names don't really matter, I went ahead and prefixed them all with the package name.
  3. There's an issue with upstream about polluting directories

@abenson abenson changed the title New package: python3-pwntools-4.1.2 New package: pwntools-4.1.2 Jun 12, 2020
@Chocimier
Copy link
Member

How well does it work for you? I can't run it because of unsatisfied unstable unicorn version, also tests of generated code fail.

@abenson
Copy link
Contributor Author

abenson commented Jun 16, 2020

Ah, the executables do fail. the libraries work fine, I'll mark this NOMERGE until unicorn 1.0.2 and pwntools are updated to use it

@abenson abenson changed the title New package: pwntools-4.1.2 [NOMERGE] New package: pwntools-4.1.2 Jun 16, 2020
@ericonr ericonr added the new-package This PR adds a new package label Dec 20, 2020
@abenson
Copy link
Contributor Author

abenson commented Jan 19, 2021

Closed in 0efc6f1

@abenson abenson closed this Jan 19, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants