Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: Itch #22863

Closed
wants to merge 1 commit into from
Closed

New package: Itch #22863

wants to merge 1 commit into from

Conversation

bugcrazy
Copy link
Contributor

Indie games client for Linux, the client is under MIT license, every game is DRM free and is delivered via direct download rather than codes you would have to enter into Steam or another launcher.

srcpkgs/itch/template Outdated Show resolved Hide resolved
srcpkgs/itch/template Outdated Show resolved Hide resolved
srcpkgs/itch/template Show resolved Hide resolved
srcpkgs/itch/template Outdated Show resolved Hide resolved
srcpkgs/itch/template Outdated Show resolved Hide resolved
Copy link
Member

@ericonr ericonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash the commits as well.

srcpkgs/itch/files/io.itch.itch.desktop Show resolved Hide resolved
Comment on lines +1 to +2
#!/bin/sh
itch-setup --prefer-launch -- "@$"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe ask for upstream to include the script? It looks useful.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, it should be exec itch-setup

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code is provided by the project, I am following the recommendation, the project does not have a script itself, but it does provide this code.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case we know better; use exec.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With EXEC, it occurs that application understands, each new startup is the first, due there is it, always does the framework download, even if you have done it previously!

2021/07/19 22:29:59 itch-setup will log to /tmp/itch-setup-log.txt
2021/07/19 22:29:59 =========================================
2021/07/19 22:29:59 itch-setup "head, no build date" starting up at "2021-07-19 22:29:59.997866826 -0300 -03 m=+0.023844080" with arguments:
2021/07/19 22:29:59 "itch-setup"
2021/07/19 22:29:59 =========================================
2021/07/19 22:29:59 App name detected: itch
2021/07/19 22:29:59 Locale: en-US
2021/07/19 22:30:00 Initializing installer GUI...
2021/07/19 22:30:00 Using GTK UI
2021/07/19 22:30:00 Initializing (itch) multiverse @ (/home/bugcrazy/.itch)
2021/07/19 22:30:00 (/home/bugcrazy/.itch)(current = "25.5.1", ready = "")
2021/07/19 22:30:00 Loading image resources...
2021/07/19 22:30:00 Setting up progress bar...
2021/07/19 22:30:00 Positioning and showing window...
2021/07/19 22:30:01 Will install version 25.5.1
2021/07/19 22:30:03 Reading signature...
2021/07/19 22:30:03 Installing 197.43 MiB (295 files, 25 dirs, 0 symlinks)
2021/07/19 22:30:03 Looks like (25.5.1) is already installed to (/home/bugcrazy/.itch/app-25.5.1)
2021/07/19 22:30:03 Let's just heal that
2021/07/19 22:30:03 Installing to (/home/bugcrazy/.itch/app-25.5.1)
2021/07/19 22:30:03 Healing (/home/bugcrazy/.itch/app-25.5.1)...
2021/07/19 22:30:07 0 B was healed @ 0 B/s (4s total)
2021/07/19 22:30:07 Healed in-place
2021/07/19 22:30:07 No validate handler, assuming good!
2021/07/19 22:30:07 Determining whether or not we've been installed via an OS package...
2021/07/19 22:30:07 Our execPath (/usr/bin/itch-setup) is somewhere in /usr, not installing desktop files
2021/07/19 22:30:07 Launching (25.5.1) from (/home/bugcrazy/.itch/app-25.5.1)
2021/07/19 22:30:07 Kernel should support SUID sandboxing, leaving it enabled
2021/07/19 22:30:07 App launched, getting out of the way

With the standard argument this does not occur.

2021/07/19 22:36:37 itch-setup will log to /tmp/itch-setup-log.txt
2021/07/19 22:36:37 =========================================
2021/07/19 22:36:37 itch-setup "head, no build date" starting up at "2021-07-19 22:36:37.731537432 -0300 -03 m=+0.078722338" with arguments:
2021/07/19 22:36:37 "itch-setup"
2021/07/19 22:36:37 "--prefer-launch"
2021/07/19 22:36:37 "--"
2021/07/19 22:36:37 "@$"
2021/07/19 22:36:37 =========================================
2021/07/19 22:36:37 App name detected: itch
2021/07/19 22:36:37 Locale: en-US
2021/07/19 22:36:37 Initializing installer GUI...
2021/07/19 22:36:37 Using GTK UI
2021/07/19 22:36:37 Initializing (itch) multiverse @ (/home/bugcrazy/.itch)
2021/07/19 22:36:37 (/home/bugcrazy/.itch)(current = "25.5.1", ready = "")
2021/07/19 22:36:37 Launch preferred, attempting...
2021/07/19 22:36:37 Launching (25.5.1) from (/home/bugcrazy/.itch/app-25.5.1)
2021/07/19 22:36:37 Kernel should support SUID sandboxing, leaving it enabled
2021/07/19 22:36:37 App launched, getting out of the way

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, why would that happen...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the author's thing of the software, who preferred to use this arguments.

srcpkgs/itch/template Outdated Show resolved Hide resolved
srcpkgs/itch/template Show resolved Hide resolved
srcpkgs/itch/template Outdated Show resolved Hide resolved
@ericonr ericonr added the new-package This PR adds a new package label Dec 20, 2020
Copy link
Member

@ericonr ericonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to figure out how to run their setup code, otherwise we have to vendor in a bunch of information...

srcpkgs/itch/template Outdated Show resolved Hide resolved
@bugcrazy bugcrazy force-pushed the patch-4 branch 2 times, most recently from 95032b1 to 1e1ec1e Compare June 18, 2021 02:16
@bugcrazy
Copy link
Contributor Author

The Lint error message is not related to the code, it is text that I wrote talking about the software, the package is built without errors.

pkgname=itch
version=1.26.0
revision=1
archs="x86_64"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this arch restricted? One can run windows games on musl...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the case with musl, compile with archs="x86_64*" and patch_args="-Np0", but application does framework donwload to work, which are compiled for GNU libc.

Which are these:

https://broth.itch.ovh/itch/linux-amd64/25.5.1/archive/default

https://broth.itch.ovh/butler/linux-amd64/15.21.0/archive/default

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it actually need the framework to go anything useful?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's electron, you need to work, I opened an issue to have musl versions of the framework.

itchio/itch#2683

@github-actions
Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

Indie games client for Linux, the client is under MIT license, every game is DRM free and is delivered via direct download rather than codes you would have to enter into Steam or another launcher.

Add file

Add shell script file

Applied suggested changes to the template

Update version

Remove i686 architecture

There is no linux-i686.zip package to download from the project's github, making it impossible to compile on i686.

Applied suggested changes

Added Patch

The version of Gotk3 0.4.0, does not compile with Go 1.16, the 0.6.0 version compiles fine!

Update to 1.26.0

Replaced nodejs-lts by nodejs, nodeJs-lts conflicts with git.
@github-actions github-actions bot closed this May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants