New package: qmidiarp-0.6.5 #23072
New package: qmidiarp-0.6.5 #23072
Conversation
| homepage="http://qmidiarp.sourceforge.net" | ||
| distfiles="${SOURCEFORGE_SITE}/project/${pkgname}/${pkgname}/${version}/${pkgname}-${version}.tar.bz2" | ||
| checksum=22a3a26d3dbe4bf215aa33c0fd4a79c088549328477840d00e72e50c6e807e10 | ||
| CXXFLAGS="-D_GNU_SOURCE" |
There was a problem hiding this comment.
since you run autoeconf anyway, patch it in?
There was a problem hiding this comment.
Hm, what would be the benefit? A patch would be more verbose and messier to maintain. The envvar is straightforward and build system agnostic...
| @@ -0,0 +1,18 @@ | |||
| # Template file for 'qmidiarp' | |||
| pkgname=qmidiarp | |||
| version=0.6.5 | |||
There was a problem hiding this comment.
This release is from 2017... Things using Qt sometimes start accumulating more and more patches :/
There was a problem hiding this comment.
Hm, IME it's not worse than with other libs. Of course, there will likely have to be a patch for Qt6 at some point.
| - EXTRA_QT_INCLUDE_DIR="$QT_INCLUDE_DIR/Qt" | ||
| - AC_CHECK_FILE([$QT_INCLUDE_DIR/QtWidgets/QWidget], | ||
| - AC_MSG_NOTICE([No extra QT_INCLUDE_DIR needed]), | ||
| - AC_CHECK_FILE([$EXTRA_QT_INCLUDE_DIR/QtWidgets/QWidget], | ||
| - QT_CPPFLAGS="$QT_CPPFLAGS -I$EXTRA_QT_INCLUDE_DIR", | ||
| - AC_MSG_WARN([QWidget not found]))) |
There was a problem hiding this comment.
Is the removal because of the -I$EXTRA_QT_INCLUDE_DIR inclusion?
There was a problem hiding this comment.
This removes a cross-unaware file existence check that breaks the build:
checking for /usr/include/qt5/QtWidgets/QWidget... configure: error: cannot check for file existence when cross compiling
=> ERROR: qmidiarp-0.6.5_1: do_configure: '${configure_script} ${configure_args}' exited with 1
=> ERROR: in do_configure() at common/build-style/gnu-configure.sh:8
It's unnecessary too, because the pkg-config based check succeeds and returns the same include paths:
checking for Qt5Core Qt5Gui Qt5Widgets >= 5.0... yes
No description provided.