Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpd: add shoutcast support #23292

Closed
wants to merge 1 commit into from
Closed

mpd: add shoutcast support #23292

wants to merge 1 commit into from

Conversation

nullenvk
Copy link
Contributor

Enables libshout support in mpd by default

@ahesford
Copy link
Member

@daniel-eys do you see any issue with adding a shoutcast build option, on by default?

@daniel-eys
Copy link
Contributor

Thanks for tagging, wasn't aware of this pr.
I see no issues here building mpd with shoutcast support by default.
Then, this needs a revbump though.

Copy link
Member

@ahesford ahesford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please either update version=0.21.25 while you're at it or, if some complication prevents the version update, bump revision=2 as @daniel-eys noted.

@nullenvk
Copy link
Contributor Author

I'm sorry, but I don't use Void Linux on any of my computers at the moment. I can update the version, but someone else will have to check it out.

@daniel-eys
Copy link
Contributor

Please update checksum= (sha256sum) as well. (and squash the commits into one)
I can confirm 0.21.25 working on x86_64.

@ahesford
Copy link
Member

I'll finish this up and merge once it passes CI.

@ahesford ahesford closed this in ceb05ea Jul 28, 2020
@nullenvk nullenvk deleted the mpd-shout branch February 11, 2021 08:31
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants