Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3-trimesh: update to 3.8.1. #23338

Closed
wants to merge 5 commits into from
Closed

python3-trimesh: update to 3.8.1. #23338

wants to merge 5 commits into from

Conversation

karl-nilsson
Copy link
Contributor

No description provided.

@Piraty
Copy link
Member

Piraty commented Jul 1, 2020

xlint: Place checkdepends= after depends=

@karl-nilsson karl-nilsson force-pushed the trimesh branch 2 times, most recently from 5c53980 to 37e62a8 Compare July 1, 2020 22:11
@karl-nilsson
Copy link
Contributor Author

@Piraty fixed, thanks

@Chocimier
Copy link
Member

TypeError: don't know how to make test from: <trimesh.exceptions.ExceptionModule object at 0x7f76eb5ce520>

passes for you?

@Piraty
Copy link
Member

Piraty commented Jul 12, 2020 •
edited

not for me. but doesn't pass for current template either

@karl-nilsson karl-nilsson force-pushed the trimesh branch 2 times, most recently from 5517247 to f75d429 Compare July 12, 2020 18:26
@karl-nilsson karl-nilsson changed the title python3-trimesh: update to 3.7.5. python3-trimesh: update to 3.7.9. Jul 12, 2020
@karl-nilsson
Copy link
Contributor Author

passes for you?

No, but the newest changes should (mostly) pass.
I'm working on packaging rtree

@karl-nilsson karl-nilsson force-pushed the trimesh branch 3 times, most recently from b057db9 to 2c565f0 Compare July 31, 2020 20:50
@Piraty
Copy link
Member

Piraty commented Aug 3, 2020

tests still don't pass, require a few more modules

@karl-nilsson karl-nilsson changed the title python3-trimesh: update to 3.7.9. python3-trimesh: update to 3.7.14. Aug 4, 2020
@karl-nilsson
Copy link
Contributor Author

tests still don't pass, require a few more modules

Strictly speaking, In order to pass all tests, all dependencies must be included:
mikedh/trimesh#590 (comment)

What's an acceptable solution: package all of requirements_easy, then have pytest do a conditional import? Or just package all requirements?

@Piraty
Copy link
Member

Piraty commented Aug 10, 2020

if it's not feasable to package the missing modules (and they're not required at runtime at all), i'd say skip do_check (but leave a comment).

@karl-nilsson karl-nilsson changed the title python3-trimesh: update to 3.7.14. python3-trimesh: update to 3.8.1. Aug 24, 2020
@karl-nilsson
Copy link
Contributor Author

@Piraty I was able to package the remaining dependencies, and make check seems to work (albeit with warnings).
Let me know what you think.

Piraty
Piraty requested changes Aug 24, 2020
View reviewed changes
Copy link
Member

@Piraty Piraty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

srcpkgs/python3-pycollada/template
revision=1
archs=noarch
wrksrc="pycollada-${version}"
#create_wrksrc=yes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove

@Piraty Piraty closed this in 244b4df Aug 24, 2020
@karl-nilsson karl-nilsson deleted the trimesh branch August 25, 2020 14:10
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Piraty Piraty Piraty requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@karl-nilsson @Piraty @Chocimier