nodejs: update to 14.7.0

[Noah-Huppert]

Works on my machine (x86_64):

% ./xbps-src pkg nodejs
% sudo xbps-install --repository "$PWD/hostdir/binpkgs/node14/" -Syu nodejs
% node -v
v14.5.0

I removed the patches b/c I assume in this version they aren't needed? Someone familiar with the package should confirm this.

[ericonr]

@q66 is it still broken for ppc?

[Noah-Huppert]

Power PC?

[Noah-Huppert]

CI build timed out. It took a long time to build on my laptop as well.

[fosslinux]

Add [ci skip] to the commit message if you push again.

[Noah-Huppert]

Pushed with CI skip.

[bn4t]

Would be great to have this merged. Currently can't use tailwindcss because of a bug in the version that's currently available in the repo.

[Noah-Huppert]

Bumping to 14.7.0 rn.

[Noah-Huppert]

Now PR is for nodejs 14.7.0. Build took ~1:30 hours so skipping the CI.

[q5sys]

This would be a really helpful update as some versions in the Node 13.x range have buggy ES module support or need --experimental-modules at the command line.

[Noah-Huppert]

Not really sure why the PR hasn't been merged...

[q5sys]

yea idk. I was thinking of seeing if I could figure out the 14.10 release but checked to see if there were any outstanding PRs for a newer version, and sure enough I found your PR.

…

On Wed, Sep 9, 2020 at 2:05 PM Noah Huppert ***@***.***> wrote: Not really sure why the PR hasn't been merged... — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#23433 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABDQJJ33KQU3K4ZZBWOSIOTSE67V7ANCNFSM4OSNF4EQ> .

[Noah-Huppert]

bumping this PR to 4.10.0 now.

[Johnnynator]

I will look into this PR this weekend.

[Noah-Huppert]

bumping this PR to 4.10.0 now.

Having issues, I wonder if 4.10.0 requires new dependencies.

  g++ -o /builddir/node-v14.10.0/out/Release/obj.target/libnode/src/node.o ../src/node.cc '-DV8_DEPRECATION_WARNINGS' '-DV8_IMMINENT_DEPRECATION_WARNINGS' '-D__STDC_FORMAT_MACROS' '-DOPENSSL_NO_PINSHARED' '-DOPENSSL_THREADS' '-DNODE_ARCH="x64"' '-DNODE_PLATFORM="linux"' '-DNODE_WANT_INTERNALS=1' '-DV8_DEPRECATION_WARNINGS=1' '-DNODE_OPENSSL_SYSTEM_CERT_PATH=""' '-DHAVE_INSPECTOR=1' '-DNODE_ENABLE_LARGE_CODE_PAGES=1' '-D__POSIX__' '-DNODE_USE_V8_PLATFORM=1' '-DNODE_HAVE_I18N_SUPPORT=1' '-DHAVE_OPENSSL=1' -I../src -I/builddir/node-v14.10.0/out/Release/obj/gen -I/builddir/node-v14.10.0/out/Release/obj/gen/include -I/builddir/node-v14.10.0/out/Release/obj/gen/src -I../deps/histogram/src -I../deps/uvwasi/include -I../deps/v8/include -I../deps/brotli/c/include -I../deps/openssl/openssl/include  -Wall -Wextra -Wno-unused-parameter -pthread -Wall -Wextra -Wno-unused-parameter -m64 -O3 -fno-omit-frame-pointer -fno-rtti -fno-exceptions -std=gnu++1y -MMD -MF /builddir/node-v14.10.0/out/Release/.deps//builddir/node-v14.10.0/out/Release/obj.target/libnode/src/node.o.d.raw     -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe  -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64  -c
../src/node.cc: In function 'int node::Start(int, char**)':
../src/node.cc:1092:42: error: 'UV_METRICS_IDLE_TIME' was not declared in this scope
 1092 |     uv_loop_configure(uv_default_loop(), UV_METRICS_IDLE_TIME);
      |                                          ^~~~~~~~~~~~~~~~~~~~
make[1]: *** [libnode.target.mk:313: /builddir/node-v14.10.0/out/Release/obj.target/libnode/src/node.o] Error 1
rm 80455764c1d44a2c5307476ee8e59d862d62cc4f.intermediate
make: *** [Makefile:104: node] Error 2
=> ERROR: nodejs-14.10.0_1: do_build: 'make LD="$CXX" LDFLAGS+=-ldl ${makejobs} V=1' exited with 2
=> ERROR:   in do_build() at srcpkgs/nodejs/template:101

[Johnnynator]

bumping this PR to 4.10.0 now.

Having issues, I wonder if 4.10.0 requires new dependencies.

  g++ -o /builddir/node-v14.10.0/out/Release/obj.target/libnode/src/node.o ../src/node.cc '-DV8_DEPRECATION_WARNINGS' '-DV8_IMMINENT_DEPRECATION_WARNINGS' '-D__STDC_FORMAT_MACROS' '-DOPENSSL_NO_PINSHARED' '-DOPENSSL_THREADS' '-DNODE_ARCH="x64"' '-DNODE_PLATFORM="linux"' '-DNODE_WANT_INTERNALS=1' '-DV8_DEPRECATION_WARNINGS=1' '-DNODE_OPENSSL_SYSTEM_CERT_PATH=""' '-DHAVE_INSPECTOR=1' '-DNODE_ENABLE_LARGE_CODE_PAGES=1' '-D__POSIX__' '-DNODE_USE_V8_PLATFORM=1' '-DNODE_HAVE_I18N_SUPPORT=1' '-DHAVE_OPENSSL=1' -I../src -I/builddir/node-v14.10.0/out/Release/obj/gen -I/builddir/node-v14.10.0/out/Release/obj/gen/include -I/builddir/node-v14.10.0/out/Release/obj/gen/src -I../deps/histogram/src -I../deps/uvwasi/include -I../deps/v8/include -I../deps/brotli/c/include -I../deps/openssl/openssl/include  -Wall -Wextra -Wno-unused-parameter -pthread -Wall -Wextra -Wno-unused-parameter -m64 -O3 -fno-omit-frame-pointer -fno-rtti -fno-exceptions -std=gnu++1y -MMD -MF /builddir/node-v14.10.0/out/Release/.deps//builddir/node-v14.10.0/out/Release/obj.target/libnode/src/node.o.d.raw     -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe  -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64  -c
../src/node.cc: In function 'int node::Start(int, char**)':
../src/node.cc:1092:42: error: 'UV_METRICS_IDLE_TIME' was not declared in this scope
 1092 |     uv_loop_configure(uv_default_loop(), UV_METRICS_IDLE_TIME);
      |                                          ^~~~~~~~~~~~~~~~~~~~
make[1]: *** [libnode.target.mk:313: /builddir/node-v14.10.0/out/Release/obj.target/libnode/src/node.o] Error 1
rm 80455764c1d44a2c5307476ee8e59d862d62cc4f.intermediate
make: *** [Makefile:104: node] Error 2
=> ERROR: nodejs-14.10.0_1: do_build: 'make LD="$CXX" LDFLAGS+=-ldl ${makejobs} V=1' exited with 2
=> ERROR:   in do_build() at srcpkgs/nodejs/template:101

https://nodejs.org/en/blog/release/v14.9.0/

^ they upgraded to libuv 1.39. So the libuv package in Void also needs updating.

[Johnnynator]

Nodejs 14 (12.18.3 also) do have a broken --shared-libuv config flag, they do link against out/Release/obj.target/deps/uv/libuv.a first, and to -luv only later. Which also should be fixed.

[leahneukirchen]

f88309c

[Noah-Huppert]

@leahneukirchen THANK YOU! Appreciate you very much 😁