Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qutebrowser: disable webengine build option where it's broken #23546

Merged
merged 2 commits into from
Jul 13, 2020
Merged

qutebrowser: disable webengine build option where it's broken #23546

merged 2 commits into from
Jul 13, 2020

Conversation

ahesford
Copy link
Member

No description provided.

@ahesford
Copy link
Member Author

After a closer look at python*-PyQt5-webengine and a comment from @Johnnynator, I realized that the file-based configuration mechanism for python*-PyQt5-webengine is broken and cross builds are simply not possible. This masqueraded as an aarch64 problem because those are the only architectures CI and the builders cross-compile that wasn't already broken for other reasons. I don't think this is worth fixing at least until PyQt5 5.15 can be packaged (which brings its own challenges), so I'm marking nocross for now.

To allow an up-to-date qutebrowser on those architectures where python*-PyQt5-webengine is no longer available, I've disabled the webengine default build option for cross builds.

cc: @Chocimier

Chocimier
Chocimier approved these changes Jul 13, 2020
View reviewed changes
srcpkgs/qutebrowser/template Outdated
@@ -21,7 +21,10 @@ build_options="webengine"
desc_option_webengine="Build Qt5 WebEngine support"

if [ "$XBPS_TARGET_ENDIAN" = "le" ]; then
if [ "$XBPS_TARGET_WORDSIZE" = "$XBPS_WORDSIZE" ]; then
# qt5-webengine is only available for little-endian systems
if [ "$XBPS_TARGET_WORDSIZE" = "$XBPS_WORDSIZE" -a -z "$CROSS_BUILD" ]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Native build imply wordsize equality.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, thanks. I also forgot to remote broken for aarch64* in python-PyQt5-webengine, which is not needed with nocross. Both are fixed.

@ahesford
python-PyQt5-webengine: mark nocross due to broken package configure …
9c7dcb6 
…script
@ahesford
qutebrowser: disable webengine for cross builds
c2da455 
python3-PyQt5-webengine is nocross because its configure script is
broken for anything but native builds. Better to have a current
qutebrowser that uses -webkit than a stale package with old -webengine.
@ahesford ahesford merged commit 9deb94f into void-linux:master Jul 13, 2020
@ahesford ahesford deleted the qutebrowser branch July 13, 2020 20:17
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Chocimier Chocimier Chocimier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ahesford @Chocimier