-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wlroots: update to 0.11.0 #23598
wlroots: update to 0.11.0 #23598
Conversation
Thanks for getting started on this! I'm following wayfire. @ahesford might know something about hikari? Not sure how it will work out for cage, we already carry a patch to make it work with |
Or well, 2h old release: https://github.com/Hjdskes/cage/releases/tag/v0.1.2.1 |
|
Given that Wayfire #595 was merged, why not just pull the patch into Void's |
@ahesford that one was just being explicit about the dependencies. See WayfireWM/wayfire#596 |
I wrote a trivial patch to make wayfire 0.4.0 build with wlroots 0.11.0 as it looks like we'll be waiting a couple of weeks for a release. As far as I know this is good to go now. |
For wayfire:
For wf-config:
|
Did you check Wayfire for crashes on startup? Apply WayfireWM/wayfire@29dcd1387700 if you see the following:
See also https://github.com/freebsd/freebsd-ports/blob/c920e5595b6/x11-wm/wayfire/files/patch-wlroots-0.11 |
I did check that it started up but didn't have any config loaded so it wasn't a great test. Thanks for the tip! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please split your last commit and move the wayfire
depends changes into the earlier wayfire
commit, then revbump the wf-config
template in the commit where you change its makedepends
. It may be unlikely, but we don't want a stale build that's been influenced by those dependencies when they are no longer in the template.
@ahesford good point, done. |
Closed in be4834d. I missed the |
This version has breaking changes, so we need to wait on new releases for the following programs and include bumps in this PR: