Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audacious #23672

Merged
merged 2 commits into from
Jul 24, 2020
Merged

Audacious #23672

merged 2 commits into from
Jul 24, 2020

Conversation

mobinmob
Copy link
Contributor

No description provided.

@ericonr
Copy link
Member

ericonr commented Jul 20, 2020

Do these versions need to be kept in sync? If so, could be nice to have a comment to that effect

@mobinmob
Copy link
Contributor Author

Do these versions need to be kept in sync? If so, could be nice to have a comment to that effect

I think they do... I should verify that before adding a comment.

@mobinmob
Copy link
Contributor Author

@ericonr Is it possible to declare a versioned runtime dep on the plugins?

@Chocimier
Copy link
Member

Is it possible to declare a versioned runtime dep on the plugins?

What do you mean?

@mobinmob
Copy link
Contributor Author

mobinmob commented Jul 22, 2020

Adding something like audacious-plugins-${version} in the depends array of the audacious template.

@Chocimier
Copy link
Member

Dependency in form of pkgname-version_revison do work in general. In this case, it would create cyclic depenency on update, thus cannot be build at all. Also audacious should not runtime depends on audacious-plugins.

Even for closer synchronization relation we use comments for now, see python3 template.

@mobinmob
Copy link
Contributor Author

@Chocimier Thank you for the explanation 👍

@mobinmob
Copy link
Contributor Author

@Chocimier @ericonr : Added comments to both templates.

@Chocimier Chocimier merged commit bf108b8 into void-linux:master Jul 24, 2020
@mobinmob mobinmob deleted the audacious branch February 5, 2021 22:13
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants