Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alsa-lib: update to 1.2.3.2. #23713

Merged
merged 1 commit into from Jul 22, 2020
Merged

Conversation

ailiop-git
Copy link
Contributor

No description provided.

@ahesford
Copy link
Member

You have other PRs, like an mpg123 update, that link against alsa-lib-devel. While it might not matter for shlib compatibility, in the future, please combine things like alsa-lib and dependants like mpg123 in a single PR with commits ordered to ensure that the new alsa-lib is built before anything that builds against it.

@ahesford ahesford merged commit dc8763d into void-linux:master Jul 22, 2020
@ailiop-git
Copy link
Contributor Author

You have other PRs, like an mpg123 update, that link against alsa-lib-devel. While it might not matter for shlib compatibility, in the future, please combine things like alsa-lib and dependants like mpg123 in a single PR with commits ordered to ensure that the new alsa-lib is built before anything that builds against it.

Since there's no shlib compatibility issue, why should those updates be combined?

@ahesford
Copy link
Member

The shlib dependency resolution in XBPS and xbps-src helps prevent a lot of problems, but that doesn't mean subtle issues can't appear when one updates a library and its headers but doesn't rebuild against the new version. Even if there are no problems, it's possible that the build objects can differ in some meaningful way when built against an older version of the library, which means versions built by xbps-src after the library is updated will be different than the official binary packages for no apparent reason.

Obviously we accept this tradeoff every time we update a library because revbumping every dependant of every library "just in case" isn't worth the cost. But if you're updating a dependent and a library within a few hours of one another, why not ensure proper ordering just to ensure consistency?

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants