New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bash: stop vendoring patch #23826
bash: stop vendoring patch #23826
Conversation
150402f
to
58256ce
Compare
Looks ok. I would commit update separately form dropping patches. Can you also change to |
Initially, I reluctant to derive it since it would involve bashism somewhere, and we may run with Now, I've re-read the code, I think we'll be fine since we asked for I'll change in a minute. |
42a2b0b
to
d2f8d86
Compare
|
On 2020-07-28 18:56:45-0700, fosslinux ***@***.***> wrote:
`xbps-src` and templates are full of a bunch of bashisms already.
I meant bootstrapping packages, which will be run by foreign distribution/OS.
…--
Danh
|
Ah, I see; although, that doesn't discount the bashisms already in xbps-src. Any foreign distribution/OS will still require bash, due to xbps-src. I don't really see any reason as a result to even bother with removing bashisms if we think xbps-src is ok on bash. |
Yes, hence I changed my mind
@Chocimier Anything else should be changed? |
conflict with #23815