Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bash: stop vendoring patch #23826

Merged
merged 6 commits into from Aug 4, 2020
Merged

bash: stop vendoring patch #23826

merged 6 commits into from Aug 4, 2020

Conversation

sgn
Copy link
Member

@sgn sgn commented Jul 25, 2020

  • carry them along won't get us anywhere
  • verify checksum for libreadline8

conflict with #23815

@sgn sgn force-pushed the bash-no-vendor branch 3 times, most recently from 150402f to 58256ce Compare July 26, 2020 05:06
@Chocimier
Copy link
Member

Looks ok. I would commit update separately form dropping patches. Can you also change to version=5.0.018 and derive rest of variables from it?

@sgn
Copy link
Member Author

sgn commented Jul 27, 2020

Looks ok. I would commit update separately form dropping patches. Can you also change to version=5.0.018 and derive rest of variables from it?

Initially, I reluctant to derive it since it would involve bashism somewhere, and we may run with /bin/sh point to something else on bootstrap.

Now, I've re-read the code, I think we'll be fine since we asked for /bin/bash directly.

I'll change in a minute.

@sgn sgn force-pushed the bash-no-vendor branch 2 times, most recently from 42a2b0b to d2f8d86 Compare July 28, 2020 07:08
@fosslinux
Copy link
Contributor

xbps-src and templates are full of a bunch of bashisms already.

@sgn
Copy link
Member Author

sgn commented Jul 29, 2020 via email

@fosslinux
Copy link
Contributor

Ah, I see; although, that doesn't discount the bashisms already in xbps-src. Any foreign distribution/OS will still require bash, due to xbps-src. I don't really see any reason as a result to even bother with removing bashisms if we think xbps-src is ok on bash.

@sgn
Copy link
Member Author

sgn commented Aug 4, 2020

Ah, I see; although, that doesn't discount the bashisms already in xbps-src. Any foreign distribution/OS will still require bash, due to xbps-src. I don't really see any reason as a result to even bother with removing bashisms if we think xbps-src is ok on bash.

Yes, hence I changed my mind

Looks ok. I would commit update separately form dropping patches. Can you also change to version=5.0.018 and derive rest of variables from it?

@Chocimier Anything else should be changed?

@Chocimier Chocimier merged commit 5ad809e into void-linux:master Aug 4, 2020
@sgn sgn deleted the bash-no-vendor branch August 22, 2020 11:14
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants