Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openexr/ilmbase: update to 2.5.2. #23989

Closed
wants to merge 71 commits into from

Conversation

skmpz
Copy link
Contributor

@skmpz skmpz commented Aug 1, 2020

locally compiled:

  • gimp: x86_64 aarch64 armv7l x86_64-musl aarch64-musl armv6l-musl
  • darktable: x86_64 aarch64 x86_64-musl aarch64-musl (archs=x86_64* aarch64* ppc64le*)
  • calligra: x86_64 aarch64 armv7l x86_64-musl aarch64-musl armv6l-musl
  • PrusaSlicer: x86_64 i686 and x86_64-musl (nocross)
  • alembic: x86_64 aarch64 armv7l x86_64-musl aarch64-musl armv6l-musl
  • hugin: x86_64 aarch64 armv7l x86_64-musl aarch64-musl armv6l-musl
  • luxmark: x86_64 (depends on embree)
  • luxrays: x86_64 (depends on embree)
  • kio-extras: x86_64 aarch64 armv7l x86_64-musl aarch64-musl armv6l-musl
  • kimageformats: x86_64 aarch64 armv7l x86_64-musl aarch64-musl armv6l-musl
  • gmic: x86_64 i686 and x86_64-musl (nocross)
  • krita: x86_64 aarch64 armv7l x86_64-musl aarch64-musl armv6l-musl
  • blender: x86_64 i686 and x86_64-musl (archs="x86_64* i686* ppc64*)
  • opencv4: x86_64 aarch64 armv7l x86_64-musl aarch64-musl armv6l-musl
  • opencv: x86_64 aarch64 armv7l x86_64-musl aarch64-musl armv6l-musl
  • openimageio: x86_64 aarch64 armv7l x86_64-musl aarch64-musl armv6l-musl
  • openvdb: x86_64 aarch64 armv7l x86_64-musl aarch64-musl armv6l-musl
  • synfig: x86_64 aarch64 armv7l x86_64-musl aarch64-musl armv6l-musl
  • synfigstudio: x86_64 aarch64 armv7l x86_64-musl aarch64-musl armv6l-musl
  • vips: x86_64 aarch64 armv7l x86_64-musl aarch64-musl armv6l-musl

@fosslinux
Copy link
Contributor

Please:

  1. Remove all of the merge commits
  2. Split the openexr/ilmbase: update to 2.5.2. commits out into 1 commit for openexr and 1 commit for ilmbase, and place them at the beginning of the commit stack.
  3. All of the miscellaneous ones at the end such as remove patches, update gmic template for 2.5 libraries and change hugin, luxmark and luxrays patches all need to follow the correct commit naming scheme. https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#committing-your-changes
  4. Ideally, the revbumps would show which of the two packages they are revbumping against. For example, kio-extras only is being revbumped for openexr.

@@ -23,7 +23,7 @@
find_library_with_debug(OPENEXR_ILMTHREAD_LIBRARY
WIN32_DEBUG_POSTFIX d
- NAMES IlmThread-2_3 IlmThread-2_2 IlmThread
+ NAMES IlmThread-2_4 IlmThread-2_3 IlmThread-2_2 IlmThread
+ NAMES ilmthread-2_5 ilmthread-2_4 ilmthread-2_3 IlmThread-2_2 IlmThread
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is case sensitive, but match the IlmThread capitalization for consistency unless the all-lowercase form is needed to work.

@skmpz
Copy link
Contributor Author

skmpz commented Aug 3, 2020

Ok guys thanks for the comments, I will do the changes and open a new PR. Closing this one.

@skmpz skmpz closed this Aug 3, 2020
@ericonr
Copy link
Member

ericonr commented Aug 3, 2020

@skmpz you can keep working on the changes here and push force, please don't close the PR to open a new one.

@pullmoll
Copy link
Member

pullmoll commented Aug 3, 2020

Thou shalt not close existing and open new PRs addressing the same issue.
Your friendly reviewer team is fed with close and open mail notifications.

Amend or edit your commits, rearrange, drop, squash, clean up and finally force push the result to the existing PR.
This is the rule, not merely a suggestion.

@skmpz skmpz reopened this Aug 3, 2020
@skmpz
Copy link
Contributor Author

skmpz commented Aug 3, 2020

Ok, reopened.

@skmpz skmpz closed this Oct 27, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 9, 2021
@skmpz skmpz deleted the openexr/ilmbase-2.5.2 branch June 17, 2022 17:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants