New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openexr/ilmbase: update to 2.5.2. #23989
Conversation
…s into openexr/ilmbase-2.5.2
…s into openexr/ilmbase-2.5.2
…s into openexr/ilmbase-2.5.2
…s into openexr/ilmbase-2.5.2
Please:
|
@@ -23,7 +23,7 @@ | |||
find_library_with_debug(OPENEXR_ILMTHREAD_LIBRARY | |||
WIN32_DEBUG_POSTFIX d | |||
- NAMES IlmThread-2_3 IlmThread-2_2 IlmThread | |||
+ NAMES IlmThread-2_4 IlmThread-2_3 IlmThread-2_2 IlmThread | |||
+ NAMES ilmthread-2_5 ilmthread-2_4 ilmthread-2_3 IlmThread-2_2 IlmThread |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this is case sensitive, but match the IlmThread
capitalization for consistency unless the all-lowercase form is needed to work.
Ok guys thanks for the comments, I will do the changes and open a new PR. Closing this one. |
@skmpz you can keep working on the changes here and push force, please don't close the PR to open a new one. |
Thou shalt not close existing and open new PRs addressing the same issue. Amend or edit your commits, rearrange, drop, squash, clean up and finally force push the result to the existing PR. |
Ok, reopened. |
locally compiled: