discord-ptb: update to 0.0.22

[MGlolenstine]

No description provided.

[fosslinux]

Thanks for your PR!

https://travis-ci.org/github/void-linux/void-packages/jobs/715664522 as you can see here, there are some xlint erorrs. Would you mind fixing them?

[MGlolenstine]

On it!

EDIT: I've been trying to find a license Discord uses, but was unable to.
it's set as "proprietary" in the file, but no SPDX is set. Now I've found this https://discord.com/terms , but I'm unsure on how to add it to the file.
Here it states that it can be a Public Domain. Does that mean that I can just insert the URL from above and we're set?

[fosslinux]

The custom: speciefier indicates it is not SPDX. Use something along the lines of custom:proprietary.

The line wrap looks good, but maybe make it consistent. I.e., if you are going to split at (I think you did) 90 characters, split the next line at 90 characters too... keep all of the lines for that block the same length.

Eg:

	for item in DiscordPTB chrome_100_percent.pak chrome_200_percent.pak icudtl.dat libEGL.so \
	libGLESv2.so libffmpeg.so locales natives_blob.bin resources resources.pak snapshot_blob.bin swiftshader v8_context_snapshot.bin; do

to

	for item in DiscordPTB chrome_100_percent.pak chrome_200_percent.pak icudtl.dat libEGL.so \
	libGLESv2.so libffmpeg.so locales natives_blob.bin resources resources.pak snapshot_blob.bin \
        swiftshader v8_context_snapshot.bin; do

[ericonr]

I believe "custom:Proprietary" is preferred. And line wraps around 80 columns, if possible.

[MGlolenstine]

I think "custom:Proprietary" had some problems with xlint and was throwing errors... I'll have to check out that tomorrow (it's midnight here) and I'm in for 80 char line wrap.

[MGlolenstine]

@ericonr This is the lint error I was talking about. I'm unsure what to put at the vlicense if anything.

[ericonr]

You might need to find an EULA or License Agreement. The spotify template, for example, has to do a similar dance.

[MGlolenstine]

You might need to find an EULA or License Agreement. The spotify template, for example, has to do a similar dance.

Would this do?
How should I format it in the file?

vlicense=https://discord.com/terms

[ericonr]

I think that file would work, but you'd have to do something like https://github.com/void-linux/void-packages/blob/master/srcpkgs/spotify/template#L23 to pre-process it.

[MGlolenstine]

I think that file would work, but you'd have to do something like https://github.com/void-linux/void-packages/blob/master/srcpkgs/spotify/template#L23 to pre-process it.

Oh wow, that looks complicated... It's pretty late here, so I'll take my time tomorrow and modify it...

[MGlolenstine]

Would this be ready for merge, or is there something still missing?

[FirstZero]

Ideally you might want to squash rebase your commits into one. Other than that, this seems ready for review.

[ericonr]

You need to squash these commits before it can be merged.

[MGlolenstine]

Ugh... I guess that squash didn't work like I wanted it to. 😅

[MGlolenstine]

This seems better.

[chilledfrogs]

BTW, just a little detail, but they moved to https://discord.com/ recently-ish @MGlolenstine, might wanna update that in homepage (for the moment the old URL is still usable though so not a huge deal)

[MGlolenstine]

BTW, just a little detail, but they moved to https://discord.com/ recently-ish @MGlolenstine, might wanna update that in homepage (for the moment the old URL is still usable though so not a huge deal)

I've just updated the URL.

[MGlolenstine]

I've updated the package to 0.0.22.
Should I close this PR and create a new one, as the version changed or would it be ok, if I just changed the commit message and PR's title?

[fosslinux]

No, you should just change the commit message and the title.

[MGlolenstine]

Should commit message contain every change or just the "discord-ptb: update to 0.0.22"?

[fosslinux]

How you have it now is correct.

[Chocimier]

@MGlolenstine Do you run this updated 0.0.22 version? Is everything ok?

[MGlolenstine]

@Chocimier Correct, I've updated it because I needed it for my laptop. I'm running it and it's working perfectly fine.