New package: r2ghidra-dec-4.5.0 #24453
Conversation
srcpkgs/r2ghidra-dec/template
Outdated
| do_fetch() { | ||
| git clone --depth 1 --branch v${version} https://github.com/radareorg/r2ghidra-dec.git ${wrksrc} | ||
| git clone --depth 1 --branch v${_cutterversion} https://github.com/radareorg/cutter.git ${wrksrc}/cutter | ||
| cd ${wrksrc} | ||
| git submodule init | ||
| git submodule update --recursive | ||
| } |
There was a problem hiding this comment.
This isn't a good solution. The build can change if they make updates to the branch. You should fetch all the files, including submodules, by adding a definitive file to distfiles. So either a tag or specific commit.
|
Once #23601 is merged, you can use it. |
|
I guess it depends. If the program works fine with the files there, it should be fine to move. Not sure what's preferred, though. |
|
I'll try if it works with moving. Also just fixed the listing in distfiles and checksum |
|
Out of curitosity, any reason this can't be built into the ghidra template? |
|
This is only the decompiler part of ghidra, which is portable and written in C++ while the rest of ghidra is written in Java. People who want to use ghidra's decompiler in radare2/cutter don't necessarily want the entire ghidra installed, and people who want to install ghidra don't necessarily want the radare2/cutter plugins installed. |
|
Arch only moves the radare2 plugin .so and not the Cutter one. I couldn't get Cutter to load the plugin when I placed it in lib, so I guess this will have to wait for #23601 to be merged. |
|
|
srcpkgs/r2ghidra-dec/template
Outdated
| f94d81919bddc5f1095250e02b1fdf57acba15e68c818d6c33088875e6759d21 | ||
| cad9cf37ec54bb98b40afc03cd5e2fdc78682fe0f235fd02c575d9b4d9443b83" | ||
|
|
||
| pre_configure() { |
There was a problem hiding this comment.
post_extract() is better.
srcpkgs/r2ghidra-dec/template
Outdated
| pkgname=r2ghidra-dec | ||
| version=4.5.0 | ||
| revision=1 | ||
| archs="x86_64" |
There was a problem hiding this comment.
Is this really only for x86_64, or is it nocross?
There was a problem hiding this comment.
ghidra seems to be x86_64*, perhaps it's the same issue? @abenson is there some comment that can be left on the template?
There was a problem hiding this comment.
Well this should then be at least x86_64* then probably.
srcpkgs/r2ghidra-dec/template
Outdated
| revision=1 | ||
| archs="x86_64" | ||
| build_style=cmake | ||
| configure_args="-DCMAKE_INSTALL_PREFIX=/usr -DBUILD_CUTTER_PLUGIN=ON -DCUTTER_SOURCE_DIR=${XBPS_BUILDDIR}/cutter-${_cutterversion}" |
There was a problem hiding this comment.
-DCMAKE_INSTALL_PREFIX=/usr is unneeded, specified in the cmake build_style. Also split across two lines, line length should be only 80 characters.
srcpkgs/r2ghidra-dec/template
Outdated
| archs="x86_64" | ||
| build_style=cmake | ||
| configure_args="-DCMAKE_INSTALL_PREFIX=/usr -DBUILD_CUTTER_PLUGIN=ON -DCUTTER_SOURCE_DIR=${XBPS_BUILDDIR}/cutter-${_cutterversion}" | ||
| ignore_elf_files="/usr/share/RadareOrg/Cutter/plugins/native/libr2ghidra_cutter.so /usr/share/radare2/plugins/core_ghidra.so" |
There was a problem hiding this comment.
Also split across two lines.
srcpkgs/r2ghidra-dec/template
Outdated
| build_style=cmake | ||
| configure_args="-DCMAKE_INSTALL_PREFIX=/usr -DBUILD_CUTTER_PLUGIN=ON -DCUTTER_SOURCE_DIR=${XBPS_BUILDDIR}/cutter-${_cutterversion}" | ||
| ignore_elf_files="/usr/share/RadareOrg/Cutter/plugins/native/libr2ghidra_cutter.so /usr/share/radare2/plugins/core_ghidra.so" | ||
| hostmakedepends="pkg-config cmake git bison flex" |
There was a problem hiding this comment.
git is no longer needed AFAICT.
|
Thanks, done |
|
Usage of ignore_elf is wrong here, because /usr/share should be still architecture independent. |
ghost
mentioned this pull request
|
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it. |
See Issue for Cutter but it is instead packaged seperate, like arch does it (PKGBUILD).
The
11-pkglint-elf-in-usrshare.shpost-install hook fails, but radare2 expects plugins in/usr/share/radare2/pluginsand Cutter expects them in/usr/share/RadareOrg/Cutter/plugins, with the only alternative being~/.local, as far as I'm aware.