Firefox 80 #24492
Merged
Firefox 80 #24492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
your reverts line is wrong |
nasm-2.15.04 breaks compilation of dav1d and thus firefox on i686 https://bugzilla.nasm.us/show_bug.cgi?id=3392715 This reverts commit 6dcc85c.
[ci skip]
thanks, fixed |
|
I have no clue. Guess there is a problem with the most recent nasm update? Do whatever is required to build firefox. |
Yes, looks like it. There is little information for now, except that it breaks building dav1d: https://bugzilla.nasm.us/show_bug.cgi?id=3392715 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build passes for all our official supported targets.
Tested on x86_64-musl with pulseaudio.
@pullmoll are you ok with the nasm revert?