Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vtk: enable bindings for python3 #24531

Closed
wants to merge 1 commit into from
Closed

vtk: enable bindings for python3 #24531

wants to merge 1 commit into from

Conversation

ahesford
Copy link
Member

cc: @Piraty

@ahesford ahesford mentioned this pull request Aug 29, 2020
Closed
@ahesford
Copy link
Member Author

OK, looks like vtk-devel has to pull in vtk-python3 now, because the CMake modules search for the python bindings. It may be possible to separate out a vtk-python3-devel subpackage that has just the CMake modules related to Python, but do we really care?

Also, CI fails because it's trying to build the latest openmpi, which hasn't hit the repo yet.

@ahesford ahesford changed the title vtk: enable bindings for python3 [NOMERGE] vtk: enable bindings for python3 Aug 29, 2020
@ahesford
Copy link
Member Author

This is not sufficient. /usr/lib/cmake/vtk-9.0/VTKPython-targets.cmake, at line 389, hard-codes the path to the vtkCommonCore CPython extension, before xbps-src mangles it to vtkCommonCore.so. CMake fails complaining that the Python extension can't be found.

@ahesford ahesford changed the title [NOMERGE] vtk: enable bindings for python3 vtk: enable bindings for python3 Aug 29, 2020
@ahesford
Copy link
Member Author

After a little vsed magic, CMake seems to work with freecad. I believe this is ready to go.

@pullmoll pullmoll closed this in eddfd41 Aug 29, 2020
@ahesford ahesford deleted the vtk branch August 29, 2020 11:29
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ahesford