Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blender: update to 2.83.5 #24644

Closed
wants to merge 4 commits into from
Closed

Conversation

jkoderu-git
Copy link
Contributor

No description provided.

Copy link
Member

@ahesford ahesford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This template circumvents proper xlint checks because of the blank lines 21 (after patch_args) and 24 (after pycompile_dirs). Please remove these blank lines and satisfy the xlint checks that will fail as a result.

Also, when moving configure_args, please make sure to indent continued lines with one space.

@ghost
Copy link

ghost commented Sep 9, 2020

Isn't 2.90 out already? Or are you guys planing on supporting the LTS versions?

@jkoderu-git
Copy link
Contributor Author

Isn't 2.90 out already? Or are you guys planing on supporting the LTS versions?

Possibly 2 packages for lts and current? Although I am not experienced to package the new 2.90.

@ghost
Copy link

ghost commented Sep 10, 2020

Alpine has 2.90 packaged but currently only x86 (testing) without Intel-embree https://github.com/embree/embree

@ahesford
Copy link
Member

You should install xtools and run xlint blender from your void-packages repo locally, because xlint sometimes takes several iterations to identify all template quality issues. Each time you iterate through CI you consume 50 minutes of time.

Regarding 2.90, I'm not a blender user, so we'll need to get some input from other users to decide whether bumping to 2.90 makes sense or a blender-lts package is appropriate.

[ci skip]
@ghost
Copy link

ghost commented Sep 10, 2020

The LTS versions are intended for larger organizations that work on bigger projects such as feature films and therefore need a version that is dependable and does not break when new features are introduced. Constant breakage could lead to unnecessary production costs.

It's unlikely that we have void-users who work in the CG industry, therefore 2.90 is probably the better option if you favor supporting only one version. However maintaining a LTS version probably won't be too difficult as they will only receive occasional bug-fixes.

@Johnnynator
Copy link
Member

I merged this with an update to 2.83.6 for now. If someone is interested in 2.90 they can feel free to open a PR for it.

@jkoderu-git jkoderu-git deleted the patch-3 branch September 25, 2020 18:50
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants