Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

siril: update to 1.0.2. #24678

Closed
wants to merge 3 commits into from
Closed

Conversation

andkem
Copy link
Contributor

@andkem andkem commented Sep 5, 2020

No description provided.

@andkem andkem force-pushed the siril-update-0.99.4 branch 3 times, most recently from dd87ab6 to 80296f8 Compare September 5, 2020 01:09
@andkem
Copy link
Contributor Author

andkem commented Sep 5, 2020

This fails cross-compilation because you're supposed to compile the bundled librtprocess separately when you cross-compile.

Is it okay to mark this as nocross or do I need to look at packaging librtprocess separately?

@ericonr
Copy link
Member

ericonr commented Sep 5, 2020

I'm not sure this is stable: https://www.siril.org/2020/08/13/siril-1-0-0beta/

But it's probably worth it to get the packaging going c:

Regarding librtprocess, given this from the build log:

configure: librtprocess not found
checking for cmake... /usr/bin/cmake
configure: librtprocess will be built statically

I'd say to either find some way to build it for cross as well, or make a package for it, which I find preferrable.

@andkem
Copy link
Contributor Author

andkem commented Sep 5, 2020

They first released 0.99.4 as a beta test for version 1.0.0, but then they decided that it was stable enough and released 0.99.4 as a proper release. (Or rather, it is still a beta version and the initial release was for Windows, Mac and Debian for testing, but has then been expanded to more platforms which makes me think this should be all right.)

They bundle the librtprocess code with Siril and build it automatically if it isn't found when you're not cross-compiling. It lives in a subdirectory and uses cmake to build.

I'll have a look at creating a proper package for librtprocess, which I think is preferable to patching the Siril build process to allow building it for cross compilation.

@andkem
Copy link
Contributor Author

andkem commented Sep 5, 2020

I could add that I've been using this version myself since the original 0.99.4 release announcement and haven't seen any stability problems or major issues myself. In fact, it has been working a lot better than the 0.9.12 release.

@andkem andkem force-pushed the siril-update-0.99.4 branch 2 times, most recently from ae5e98f to 80fcf10 Compare September 5, 2020 20:45
@andkem andkem changed the title siril: update to 0.99.4. siril: update to 0.99.6. Sep 23, 2020
@andkem
Copy link
Contributor Author

andkem commented Sep 23, 2020

0.99.6 was released. It is still a 1.0 beta although they consider it better than 0.9.12.

@andkem andkem changed the title siril: update to 0.99.6. siril: update to 0.99.8.1. Feb 14, 2021
@andkem
Copy link
Contributor Author

andkem commented Feb 14, 2021

Version 0.99.8.1 was released. Keeping MR up to date.

@andkem andkem force-pushed the siril-update-0.99.4 branch 3 times, most recently from 5f5b44a to 82403a5 Compare February 14, 2021 19:10
distfiles="ftp://ftp.atnf.csiro.au/pub/software/${pkgname}/${pkgname}-${version}.tar.bz2"
checksum=a21c964136055ad1d68ca9d3e9714374a9dc3ff2f7072622af08cc4f5a0c511c

if [ "$XBPS_CROSS_BUILD" ]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if [ "$XBPS_CROSS_BUILD" ]; then
if [ "$CROSS_BUILD" ]; then

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

# make check doesn't really do anything and is broken.
do_check() {
:
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the new make_check=no

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

fi

wcslib-devel_package() {
short_desc="Tools for WCS in FITS headers - development files"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
short_desc="Tools for WCS in FITS headers - development files"
short_desc+=" - development files"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@andkem andkem force-pushed the siril-update-0.99.4 branch 2 times, most recently from ec36ad5 to d047081 Compare May 27, 2021 18:51
@andkem
Copy link
Contributor Author

andkem commented May 27, 2021

Keeping this PR compiling by adding a few patches I'm looking at upstreaming and adding a missing NDEBUG to librtprocess.

@andkem andkem changed the title siril: update to 0.99.8.1. siril: update to 0.99.10. Jun 17, 2021
@andkem
Copy link
Contributor Author

andkem commented Jun 17, 2021

Siril 0.99.10 was released. Keeping PR up to date.

@andkem andkem changed the title siril: update to 0.99.10. siril: update to 1.0.0. Mar 10, 2022
@andkem
Copy link
Contributor Author

andkem commented Mar 10, 2022

Siril 1.0.0 was finally released. Since the 0.9.12 release has been considered deprecated for a few years now, I would love it if we could finally get the Siril package updated.

@andkem andkem force-pushed the siril-update-0.99.4 branch 2 times, most recently from a116093 to 475327f Compare March 10, 2022 23:42
@andkem andkem changed the title siril: update to 1.0.0. siril: update to 1.0.2. May 17, 2022
@andkem
Copy link
Contributor Author

andkem commented May 17, 2022

Bumped Siril to 1.0.2 to keep the PR up to date.

cross-compile-fix.patch replaces calls to AC_CHECK_FILE with using the
test utility since it, by design, does not work when cross-compiling.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants