New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
next: rename to nyxt and bump to version 2.0.0 #24765
Conversation
I'm not quite sure how to address package renaming. I would appreciate any help. |
Some more stuff is needed, see https://github.com/void-linux/void-packages/blob/master/Manual.md#subpackages |
Also please force push branch rather than opening new PRs. |
thanks for the pointer. |
still having trouble, the documentation doesn't describe how to handle such cases :( |
Basically the subpackage should depend on the new one. So let Also its good to look at examples on how its done, it's been done with riot/element recently: #23587 |
thanks for the pointer, i tried to find an example, but how do you find it if you don't know what to look for :) |
One more question: when is it save to kill the dummy 'next' package then ? |
Normally there will be a long time before that happens. Don't worry about that right now. |
Since it is still installed as /usr/bin/next, rename could wait for next version. There is already pre-release of version 2.
|
I agree, makes sense, i'll update the pull request as soon as it is available. |
Is this still going to happen? |
It seems somebody already bumped next to 1.5.0 but it wasn't renamed to nyxt, what to do ? |
The project has been renamed to nyxt, but the executable seems to still be next. I don't know which direction the package should go. |
Version 1.5.0 was released under name next. Renaming was done later: https://github.com/atlas-engineer/nyxt/blob/master/documents/CHANGELOG.org#2-pre-release-1 .
|
60d429a
to
0c6329f
Compare
Finally, the day of nyxt release 2.0.0 arrived. |
srcpkgs/nyxt/template
Outdated
build_style=gnu-makefile | ||
hostmakedepends="sbcl curl pkg-config git" | ||
makedepends="webkit2gtk-devel libfixposix-devel openssl-devel libgirepository-devel" | ||
depends="dbus sqlite xclip libfixposix-devel openssl-devel libgirepository-devel" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are library headers really needed runtime?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
srcpkgs/nyxt/template
Outdated
maintainer="0x0f0f0f <sudo-woodo3@protonmail.com>" | ||
license="BSD-3-Clause" | ||
homepage="https://nyxt.atlas.engineer/" | ||
distfiles="https://nyxt.atlas.engineer/static/release/nyxt.tar.gz" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use versioned tarball. Github has one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a problem because the release archive on github is broken (doesn't contain submodules) and the developer uploaded a fixed one here: https://nyxt.atlas.engineer/static/release/nyxt.tar.gz after i talked to him.
srcpkgs/nyxt/template
Outdated
checksum=71154bc6ef88f176f3f7783e1c0ecc191b6dcdd996e1c67f2bbc417b651e0355 | ||
nostrip=yes | ||
nopie=yes | ||
nocross="https://travis-ci.org/void-linux/void-packages/builds/590346382" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess not overriding do_build would make it compile.
Link already expired, please push without nocross so we can see logs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do_build is required because the first target in Makefile is help, unfortunately.
|
Thank you very much. Fixed all raised issues. Negotiating now a versioned archive with nyxt devs. |
4106490
to
764e2c9
Compare
Nyxt devs provided a new URL for the versioned archive 2.0.0. |
Added some devel packages as runtime deps that are needed to load libraries by unversioned name. |
@Chocimier I'm having an issue on the master branch which may or may not have been by this merge
|
Seems to work for me with no issues, maybe cleanup first ? |
Same issue after
not sure if there's something specific you're referring to with |
Hmm |
Just tried it on my other Void host and it worked there, so that's strange. |
@simvux: This may be because of old mesa-opencl build before. |
No description provided.