Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

next: rename to nyxt and bump to version 2.0.0 #24765

Merged
merged 1 commit into from Jun 5, 2021

Conversation

egorenar
Copy link
Contributor

@egorenar egorenar commented Sep 8, 2020

No description provided.

@egorenar
Copy link
Contributor Author

egorenar commented Sep 8, 2020

I'm not quite sure how to address package renaming. I would appreciate any help.
Thank you

@Chocimier
Copy link
Member

@Chocimier
Copy link
Member

Also please force push branch rather than opening new PRs.

@egorenar
Copy link
Contributor Author

egorenar commented Sep 8, 2020

thanks for the pointer.
i just messed up something with the old PR and it closed automatically :(

@egorenar
Copy link
Contributor Author

egorenar commented Sep 8, 2020

still having trouble, the documentation doesn't describe how to handle such cases :(

@Anachron
Copy link
Contributor

Anachron commented Sep 8, 2020

Basically the subpackage should depend on the new one. So let next depend on nyxt.

Also its good to look at examples on how its done, it's been done with riot/element recently: #23587

@egorenar
Copy link
Contributor Author

egorenar commented Sep 9, 2020

thanks for the pointer, i tried to find an example, but how do you find it if you don't know what to look for :)

@egorenar
Copy link
Contributor Author

egorenar commented Sep 9, 2020

One more question: when is it save to kill the dummy 'next' package then ?

@Anachron
Copy link
Contributor

Anachron commented Sep 9, 2020

Normally there will be a long time before that happens. Don't worry about that right now.

@Chocimier
Copy link
Member

Since it is still installed as /usr/bin/next, rename could wait for next version. There is already pre-release of version 2.
Otherwise, increase revision, as next package is empty now.

subpackages= is not needed, see Manual for explanation.

@egorenar
Copy link
Contributor Author

egorenar commented Sep 9, 2020

Since it is still installed as /usr/bin/next, rename could wait for next version. There is already pre-release of version 2.

I agree, makes sense, i'll update the pull request as soon as it is available.
Thanks

@ericonr
Copy link
Member

ericonr commented Jan 29, 2021

Is this still going to happen?

@egorenar
Copy link
Contributor Author

It seems somebody already bumped next to 1.5.0 but it wasn't renamed to nyxt, what to do ?

@ericonr
Copy link
Member

ericonr commented Jan 29, 2021

The project has been renamed to nyxt, but the executable seems to still be next. I don't know which direction the package should go.

@Chocimier
Copy link
Member

Version 1.5.0 was released under name next. Renaming was done later: https://github.com/atlas-engineer/nyxt/blob/master/documents/CHANGELOG.org#2-pre-release-1 .
They do pre-releases monthly https://github.com/atlas-engineer/nyxt/tags , so we can just wait for stable release and rename on update.

somebody bumped

#19326

@egorenar egorenar force-pushed the nyxt branch 2 times, most recently from 60d429a to 0c6329f Compare June 5, 2021 11:19
@egorenar
Copy link
Contributor Author

egorenar commented Jun 5, 2021

Finally, the day of nyxt release 2.0.0 arrived.

@0x0f0f0f

build_style=gnu-makefile
hostmakedepends="sbcl curl pkg-config git"
makedepends="webkit2gtk-devel libfixposix-devel openssl-devel libgirepository-devel"
depends="dbus sqlite xclip libfixposix-devel openssl-devel libgirepository-devel"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are library headers really needed runtime?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

maintainer="0x0f0f0f <sudo-woodo3@protonmail.com>"
license="BSD-3-Clause"
homepage="https://nyxt.atlas.engineer/"
distfiles="https://nyxt.atlas.engineer/static/release/nyxt.tar.gz"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use versioned tarball. Github has one.

Copy link
Contributor Author

@egorenar egorenar Jun 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a problem because the release archive on github is broken (doesn't contain submodules) and the developer uploaded a fixed one here: https://nyxt.atlas.engineer/static/release/nyxt.tar.gz after i talked to him.

checksum=71154bc6ef88f176f3f7783e1c0ecc191b6dcdd996e1c67f2bbc417b651e0355
nostrip=yes
nopie=yes
nocross="https://travis-ci.org/void-linux/void-packages/builds/590346382"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess not overriding do_build would make it compile.
Link already expired, please push without nocross so we can see logs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do_build is required because the first target in Makefile is help, unfortunately.

@Chocimier
Copy link
Member

  • leave comment on make_check that it is because ASDF/USER::PROVE is not installed
  • cross compilation fail due to iolib/syscalls setting compiler flags wrong, please enable again with explaination rather than link
  • set make_build_target=all instead of overwriting do_build
  • would be best if uploaded tarball was to versioned, but as is can be accepted too

@egorenar
Copy link
Contributor Author

egorenar commented Jun 5, 2021

  • leave comment on make_check that it is because ASDF/USER::PROVE is not installed
  • cross compilation fail due to iolib/syscalls setting compiler flags wrong, please enable again with explaination rather than link
  • set make_build_target=all instead of overwriting do_build
  • would be best if uploaded tarball was to versioned, but as is can be accepted too

Thank you very much. Fixed all raised issues. Negotiating now a versioned archive with nyxt devs.

@egorenar egorenar force-pushed the nyxt branch 3 times, most recently from 4106490 to 764e2c9 Compare June 5, 2021 13:49
@egorenar
Copy link
Contributor Author

egorenar commented Jun 5, 2021

Nyxt devs provided a new URL for the versioned archive 2.0.0.

@egorenar egorenar changed the title next: rename to nyxt next: rename to nyxt mand bump to version 2.0.0 Jun 5, 2021
@egorenar egorenar changed the title next: rename to nyxt mand bump to version 2.0.0 next: rename to nyxt and bump to version 2.0.0 Jun 5, 2021
@Chocimier
Copy link
Member

Added some devel packages as runtime deps that are needed to load libraries by unversioned name.
Thanks.

@Chocimier Chocimier merged commit 9bd2879 into void-linux:master Jun 5, 2021
@simvux
Copy link

simvux commented Jun 6, 2021

@Chocimier I'm having an issue on the master branch which may or may not have been by this merge

 [] : /home/simon/v -> ./xbps-src pkg nyxt
=> xbps-src: updating repositories for host (x86_64)...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/x86_64-repodata' ...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/nonfree/x86_64-repodata' ...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/debug/x86_64-repodata' ...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/multilib/x86_64-repodata' ...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/multilib/nonfree/x86_64-repodata' ...
=> xbps-src: updating software in / masterdir...
=> xbps-src: cleaning up / masterdir...
=> nyxt-2.0.0_1: removing autodeps, please wait...
=> nyxt-2.0.0_1: building [gnu-makefile] for x86_64...
   [host] sbcl-2.1.5_1: found (https://alpha.de.repo.voidlinux.org/current)
   [host] curl-7.77.0_1: found (https://alpha.de.repo.voidlinux.org/current)
   [host] pkg-config-0.29.2_2: found (https://alpha.de.repo.voidlinux.org/current)
   [host] git-2.31.1_1: found (https://alpha.de.repo.voidlinux.org/current)
   [target] webkit2gtk-devel-2.32.1_2: found (https://alpha.de.repo.voidlinux.org/current)
   [target] libfixposix-devel-0.4.3_1: found (https://alpha.de.repo.voidlinux.org/current)
   [target] openssl-devel-1.1.1k_1: found (https://alpha.de.repo.voidlinux.org/current)
   [target] libgirepository-devel-1.68.0_1: not found
   [runtime] dbus-1.12.20_1: found (https://alpha.de.repo.voidlinux.org/current)
   [runtime] sqlite-3.35.5_1: found (https://alpha.de.repo.voidlinux.org/current)
   [runtime] xclip-0.13_1: found (https://alpha.de.repo.voidlinux.org/current)
   [runtime] webkit2gtk-devel-2.32.1_2: found (https://alpha.de.repo.voidlinux.org/current)
   [runtime] libgirepository-devel-1.68.0_1: not found
   [runtime] nyxt-2.0.0_1: found (https://alpha.de.repo.voidlinux.org/current)
=> nyxt-2.0.0_1: installing host dependencies: sbcl-2.1.5_1 curl-7.77.0_1 pkg-config-0.29.2_2 git-2.31.1_1 ...
=> nyxt-2.0.0_1: installing target dependencies: webkit2gtk-devel-2.32.1_2 libfixposix-devel-0.4.3_1 openssl-devel-1.1.1k_1 libgirepository-devel-1.68.0_1 ...
=> nyxt-2.0.0_1: removing autodeps, please wait...
=> ERROR: nyxt-2.0.0_1: failed to install 'webkit2gtk-devel-2.32.1_2' dependency! (error 8)
mesa-opencl-21.0.1_1: broken, unresolvable shlib `libclang-cpp.so.11'
Transaction aborted due to unresolved shlibs.
=> ERROR: Please see above for the real error, exiting...

@egorenar
Copy link
Contributor Author

egorenar commented Jun 6, 2021

@Chocimier I'm having an issue on the master branch which may or may not have been by this merge

 [] : /home/simon/v -> ./xbps-src pkg nyxt
=> xbps-src: updating repositories for host (x86_64)...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/x86_64-repodata' ...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/nonfree/x86_64-repodata' ...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/debug/x86_64-repodata' ...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/multilib/x86_64-repodata' ...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/multilib/nonfree/x86_64-repodata' ...
=> xbps-src: updating software in / masterdir...
=> xbps-src: cleaning up / masterdir...
=> nyxt-2.0.0_1: removing autodeps, please wait...
=> nyxt-2.0.0_1: building [gnu-makefile] for x86_64...
   [host] sbcl-2.1.5_1: found (https://alpha.de.repo.voidlinux.org/current)
   [host] curl-7.77.0_1: found (https://alpha.de.repo.voidlinux.org/current)
   [host] pkg-config-0.29.2_2: found (https://alpha.de.repo.voidlinux.org/current)
   [host] git-2.31.1_1: found (https://alpha.de.repo.voidlinux.org/current)
   [target] webkit2gtk-devel-2.32.1_2: found (https://alpha.de.repo.voidlinux.org/current)
   [target] libfixposix-devel-0.4.3_1: found (https://alpha.de.repo.voidlinux.org/current)
   [target] openssl-devel-1.1.1k_1: found (https://alpha.de.repo.voidlinux.org/current)
   [target] libgirepository-devel-1.68.0_1: not found
   [runtime] dbus-1.12.20_1: found (https://alpha.de.repo.voidlinux.org/current)
   [runtime] sqlite-3.35.5_1: found (https://alpha.de.repo.voidlinux.org/current)
   [runtime] xclip-0.13_1: found (https://alpha.de.repo.voidlinux.org/current)
   [runtime] webkit2gtk-devel-2.32.1_2: found (https://alpha.de.repo.voidlinux.org/current)
   [runtime] libgirepository-devel-1.68.0_1: not found
   [runtime] nyxt-2.0.0_1: found (https://alpha.de.repo.voidlinux.org/current)
=> nyxt-2.0.0_1: installing host dependencies: sbcl-2.1.5_1 curl-7.77.0_1 pkg-config-0.29.2_2 git-2.31.1_1 ...
=> nyxt-2.0.0_1: installing target dependencies: webkit2gtk-devel-2.32.1_2 libfixposix-devel-0.4.3_1 openssl-devel-1.1.1k_1 libgirepository-devel-1.68.0_1 ...
=> nyxt-2.0.0_1: removing autodeps, please wait...
=> ERROR: nyxt-2.0.0_1: failed to install 'webkit2gtk-devel-2.32.1_2' dependency! (error 8)
mesa-opencl-21.0.1_1: broken, unresolvable shlib `libclang-cpp.so.11'
Transaction aborted due to unresolved shlibs.
=> ERROR: Please see above for the real error, exiting...

Seems to work for me with no issues, maybe cleanup first ?

@simvux
Copy link

simvux commented Jun 6, 2021

Same issue after

./xbps-src clean-repocache
./xbps-src zap
./xbps-src binary-bootstrap
/xbps-src clean nyxt
sudo xbps-remove -yO
sudo xbps-remove -yo

./xbps-src pkg nyx

not sure if there's something specific you're referring to with cleanup

@egorenar
Copy link
Contributor Author

egorenar commented Jun 6, 2021

Hmm mesa-opencl-21.0.1_1: broken, unresolvable shlib libclang-cpp.so.11, no mesa-opencl dependency is installed for me.

@simvux
Copy link

simvux commented Jun 6, 2021

Just tried it on my other Void host and it worked there, so that's strange.

@Chocimier
Copy link
Member

@simvux: This may be because of old mesa-opencl build before.
Can you paste output of xbps-query -i --repository=hostdir/binpkgs mesa-opencl executed in void-packages clone where nyxt don't build?

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants