Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: zenpower-dkms-0.1.12 #24807

Closed
wants to merge 1 commit into from

Conversation

2asoft
Copy link
Contributor

@2asoft 2asoft commented Sep 10, 2020

This adds a Linux kernel driver for reading sensors for AMD Zen family CPUs (as a DKMS module).
I did not write the code, merely the package template.

Verified on a B550I AORUS PRO AX with a Ryzen 5 3600.

Without this module:

% sensors
No sensors found!
Make sure you loaded all the kernel drivers you need.
Try sensors-detect to find out which these are.

With this module:

% sensors
zenpower-pci-00c3
Adapter: PCI adapter
SVI2_Core:    +0.91 V
SVI2_SoC:     +1.09 V
Tdie:         +40.0°C  (high = +95.0°C)
Tctl:         +40.0°C
Tccd1:        +40.2°C
SVI2_P_Core:   5.45 W
SVI2_P_SoC:   11.91 W
SVI2_C_Core:  +5.27 A
SVI2_C_SoC:  +11.18 A

@hippi777
Copy link

hi there :)

i think if this will be accepted (why not), then a pointer to it from the docs could be useful for those who are affected, but im not sure about the related policies, just i guess it fits...

bests! :)

Comment on lines 20 to 22
sed -e "s/@CFLGS@//" \
-e "s/@VERSION@/${version}-${revision}/" \
-i "${PKGDESTDIR}/usr/src/${_pkgname}-${version}/dkms.conf"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use vsed.

maintainer="Anton Afanasyev <anton@doubleasoftware.com>"
license="GPL-2.0-only"
homepage="https://github.com/ocerman/zenpower"
distfiles="https://github.com/ocerman/$_pkgname/archive/v${version}.tar.gz"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to put $_pkgname here, either use the full URL or replace it with ${homepage}.

_pkgname=zenpower
version=0.1.12
revision=1
archs="x86_64"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
archs="x86_64"
archs="x86_64*"

do_install() {
vmkdir /usr/src/${_pkgname}-${version}
vcopy "./*" usr/src/${_pkgname}-${version}
sed -e "s/@CFLGS@//" \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using vsed is preferred. Could mention that this is taken from the makefile, too.

Comment on lines +24 to +27
# modules-load.d(5) file.
vmkdir usr/lib/modules-load.d
echo "${_pkgname}" > ${DESTDIR}/usr/lib/modules-load.d/${_pkgname}.conf
chmod 644 ${DESTDIR}/usr/lib/modules-load.d/${_pkgname}.conf
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be left for the user to do?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other Void ports that carry DKMS modules that I've seen also install said modules; I just followed the existing "example".

@github-actions
Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label May 15, 2022
@github-actions github-actions bot closed this May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants