New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: zenpower-dkms-0.1.12 #24807
Conversation
hi there :) i think if this will be accepted (why not), then a pointer to it from the docs could be useful for those who are affected, but im not sure about the related policies, just i guess it fits... bests! :) |
ca6449e
to
27f27b2
Compare
27f27b2
to
9274338
Compare
9274338
to
2eeef98
Compare
srcpkgs/zenpower-dkms/template
Outdated
sed -e "s/@CFLGS@//" \ | ||
-e "s/@VERSION@/${version}-${revision}/" \ | ||
-i "${PKGDESTDIR}/usr/src/${_pkgname}-${version}/dkms.conf" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use vsed
.
srcpkgs/zenpower-dkms/template
Outdated
maintainer="Anton Afanasyev <anton@doubleasoftware.com>" | ||
license="GPL-2.0-only" | ||
homepage="https://github.com/ocerman/zenpower" | ||
distfiles="https://github.com/ocerman/$_pkgname/archive/v${version}.tar.gz" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to put $_pkgname
here, either use the full URL or replace it with ${homepage}
.
srcpkgs/zenpower-dkms/template
Outdated
_pkgname=zenpower | ||
version=0.1.12 | ||
revision=1 | ||
archs="x86_64" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
archs="x86_64" | |
archs="x86_64*" |
2eeef98
to
65cb722
Compare
srcpkgs/zenpower3-dkms/template
Outdated
do_install() { | ||
vmkdir /usr/src/${_pkgname}-${version} | ||
vcopy "./*" usr/src/${_pkgname}-${version} | ||
sed -e "s/@CFLGS@//" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using vsed
is preferred. Could mention that this is taken from the makefile, too.
# modules-load.d(5) file. | ||
vmkdir usr/lib/modules-load.d | ||
echo "${_pkgname}" > ${DESTDIR}/usr/lib/modules-load.d/${_pkgname}.conf | ||
chmod 644 ${DESTDIR}/usr/lib/modules-load.d/${_pkgname}.conf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be left for the user to do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other Void ports that carry DKMS modules that I've seen also install said modules; I just followed the existing "example".
65cb722
to
4d58d28
Compare
4d58d28
to
d056aed
Compare
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it. |
This adds a Linux kernel driver for reading sensors for AMD Zen family CPUs (as a DKMS module).
I did not write the code, merely the package template.
Verified on a B550I AORUS PRO AX with a Ryzen 5 3600.
Without this module:
% sensors No sensors found! Make sure you loaded all the kernel drivers you need. Try sensors-detect to find out which these are.
With this module: