Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 2 drop #24995

Closed
wants to merge 66 commits into from
Closed

Python 2 drop #24995

wants to merge 66 commits into from

Conversation

sgn
Copy link
Member

@sgn sgn commented Sep 20, 2020

I pushed part of this out.
Now I think I should let other people have a comment.

Things was filtered by:

  • python libraries, with no other executable depends on it or no non-python depends on it

@sgn sgn force-pushed the python-2-drop branch 5 times, most recently from 112629d to ce03e98 Compare September 20, 2020 14:42
ericonr
ericonr reviewed Sep 20, 2020
View reviewed changes
Copy link
Member

@ericonr ericonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if we need to be specific about "Python3" in package descriptions, since it should be the default now, and it's in the package name...

srcpkgs/python3-SPARQLWrapper/template
build_style=python3-module
hostmakedepends="python3-setuptools"
depends="python3-rdflib"
short_desc="SPARQL Endpoint interface to Python (Python3)"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"interface to Python3" ? A bit shorter

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I convert via a script :-p

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eh, if it's done already I don't think it's bad to keep it :P

srcpkgs/python3-ldap3/template
build_style=python3-module
hostmakedepends="python3-setuptools"
depends="python3-pyasn1"
short_desc="Strictly RFC 4510 conforming LDAP V3 pure Python client (Python3)"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"pure Python3 client" ? Or not even mention Python3, since it's in the package name and should be the default now.

@benalb
Copy link
Contributor

benalb commented Sep 20, 2020

python-dominate and python-mtranslate are also candidates to the drop.

@ericonr
Copy link
Member

ericonr commented Sep 20, 2020

Hmm you included some commits from master here.

@sgn
python-redis: drop package
7342d72
@sgn
python-rebulk: drop package
9890231
@sgn
python-readability-lxml: drop package
42e48ab
@sgn
python-SPARQLWrapper: drop package
39e3fef
@sgn
python-raven: drop package
094a273
@sgn
python-rarfile: drop package
4005ec4
@sgn
python-random2: drop package
a28c5d9
@sgn
python-qrcode: drop package
1e5a8b3
@sgn
python-pyzbar: drop package
1eb3340
@sgn
python-pyx: drop package
478f180
@sgn
python-pyudev: drop package
eaecf81
@sgn
python-pytest-fixture-config: drop package
374a7ff
@sgn
python-pytest-mock: drop package
c2ca2c1
@sgn
python-pysrt: drop package
5469e83
@sgn
python-pysocks: drop package
fee7347
@sgn
python-pyrfc3339: drop package
b5a245b
@sgn
python-pyqtgraph: drop package
2fee116
@sgn
python-pyperclip: drop package
dca6508
@sgn
python-pypcapfile: drop package
47a2036
@sgn
python-pyotp: drop package
e2458d2
@sgn
python-pykka: drop package
77b98a0
@sgn
python-pipenv: drop package
745e75b
@sgn
python-pickleshare: drop package
228647b
@sgn
python-picamera: drop package
a8ecd07
@sgn
python-pgmigrate: drop package
3eb3ce7
@sgn
python-pdfrw: drop package
7197bbc
@sgn
python-pbkdf2: drop package
9cce9f4
@sgn
python-pathtools: drop package
7ed4002
@sgn
python-pathspec: drop package
5aa20c1
@sgn
python-pyscss: drop package
e2fd6a3
@sgn
python-pathlib: drop package
12ad312
@sgn
python-passlib: drop package
d59301b
@sgn
python-bibtexparser: drop package
3e9d829
@sgn
python-parse: drop package
9163ce3
@sgn
python-pandocfilters: drop package
d0ebd47
@sgn
python-pam: drop package
b8dea6e
@sgn
python-ndg_httpsclient: drop package
e4cbf9c
@sgn
python-natsort: drop package
44a9667
@sgn
python-olefile: drop package
3951fd7
@sgn
python-discogs_client: drop package
90dc328
@sgn
python-oauthlib: drop package
7626bfe
@sgn
python-ntplib: drop package
5cb0a2e
@sgn
python3-ntplib: update to 0.3.4.
12a9667
@sgn
python3-pyscss: update to 1.3.7.
df4c64d 
1.3.5 could NOT be built with setuptools 47+
@fosslinux
Copy link
Contributor

How did you decide which packages to drop?

Partially supersees #24986

@sgn
Copy link
Member Author

sgn commented Sep 20, 2020

How did you decide which packages to drop?

Partially supersees #24986

  • Python Executable: that has Python 3 counterpart, no other Python 2 package depends on Python 2 version
  • Python 2 Libraries: that only depended by first item (and by chain, to this item)

For example: buildbot and offlineimap will stay, and its dependencies will stay. For now, I picked the package from your PR.

@sgn sgn mentioned this pull request Sep 21, 2020
Closed
@sgn sgn closed this in 0a6e743 Sep 22, 2020
@sgn sgn deleted the python-2-drop branch October 9, 2020 13:48
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ericonr ericonr ericonr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sgn @benalb @ericonr @fosslinux