Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github-cli: install shell completion #25013

Merged
merged 1 commit into from
Sep 23, 2020

Conversation

gbrlsnchs
Copy link
Contributor

No description provided.

@gbrlsnchs
Copy link
Contributor Author

CI is throwing the error cannot execute binary file: Exec format error for ARM architectures. Does this mean this package was silently passing but was compiling a non-functional non-ARM binary?

@ericonr
Copy link
Member

ericonr commented Sep 21, 2020

No. The ARM binaries are cross compiled, so the host machine can't execute them. To generate completions, use vtargetrun, as in the rustup template.

@gbrlsnchs
Copy link
Contributor Author

No. The ARM binaries are cross compiled, so the host machine can't execute them. To generate completions, use vtargetrun, as in the rustup template.

Duh, my bad. And TIL about vtargetrun, thanks!

It now seems to be working but some CI jobs have timed out. 😞

@gbrlsnchs
Copy link
Contributor Author

@ericonr, do you have permission to rerun the CI jobs? I think everything's fine and working, it has just timed out.

@ericonr
Copy link
Member

ericonr commented Sep 23, 2020

@gbrlsnchs you can rebase your branch and force push it. That should restart CI.

@gbrlsnchs
Copy link
Contributor Author

All right, @ericonr, all good now, thanks for the tip.

Comment on lines 27 to 28
gopath=$(go env GOPATH)
gh=$(find $gopath/bin -name gh)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We set GOPATH for the build, so it should work just as well with find $GOPATH/bin

@gbrlsnchs gbrlsnchs force-pushed the github-cli-completion branch 3 times, most recently from d2b3dda to 95ca67b Compare September 23, 2020 20:23
@gbrlsnchs
Copy link
Contributor Author

@ericonr All good now.

@ericonr ericonr merged commit 74ef0f1 into void-linux:master Sep 23, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants