-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
github-cli: install shell completion #25013
Conversation
CI is throwing the error |
No. The ARM binaries are cross compiled, so the host machine can't execute them. To generate completions, use |
e3f4b31
to
72f5d19
Compare
Duh, my bad. And TIL about It now seems to be working but some CI jobs have timed out. 😞 |
@ericonr, do you have permission to rerun the CI jobs? I think everything's fine and working, it has just timed out. |
@gbrlsnchs you can rebase your branch and force push it. That should restart CI. |
72f5d19
to
7dcca85
Compare
All right, @ericonr, all good now, thanks for the tip. |
srcpkgs/github-cli/template
Outdated
gopath=$(go env GOPATH) | ||
gh=$(find $gopath/bin -name gh) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We set GOPATH
for the build, so it should work just as well with find $GOPATH/bin
d2b3dda
to
95ca67b
Compare
95ca67b
to
6cc5d27
Compare
@ericonr All good now. |
No description provided.