Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: xnotify-0.8.1 #25035

Closed
wants to merge 1 commit into from
Closed

Conversation

natrys
Copy link
Contributor

@natrys natrys commented Sep 22, 2020

No description provided.

@natrys
Copy link
Contributor Author

natrys commented Sep 22, 2020

Alternative is maybe to patch up config.mk in ugly ways: https://gist.github.com/natrys/7a6f21699277809464cffd7851479741

Dunno whichever (or if neither) way is more idiomatic.

@natrys natrys changed the title New package: xnotify-0.3.1 New package: xnotify-0.5.0 Sep 29, 2020
@ericonr ericonr added the new-package This PR adds a new package label Dec 20, 2020
@biopsin
Copy link
Contributor

biopsin commented Apr 28, 2021

@natrys Ping & bump to 0.8.1
Would you mind adopt make_build_args from 81f88f2
and drop the freetype-devel dependency.
Also include "Closes PR #27198"

@natrys
Copy link
Contributor Author

natrys commented Apr 28, 2021

hi @biopsin do you mean:

make_build_args="LOCALINC=${XBPS_CROSS_BASE}/usr/include
 LOCALLIB=${XBPS_CROSS_BASE}/usr/lib
 FREETYPEINC=${XBPS_CROSS_BASE}/usr/include/freetype2
 X11INC=${XBPS_CROSS_BASE}/usr/include/X11
 LDFLAGS+=\$(LIBS) CFLAGS+=\$(INCS)"

This works but I feel like this is more indirect and implicit than just setting up CFLAGS/LDFLAGS directly which is the desired effect.

CFLAGS="-I${XBPS_CROSS_BASE}/usr/include"
CFLAGS+=" -I${XBPS_CROSS_BASE}/usr/include/X11"
CFLAGS+=" -I${XBPS_CROSS_BASE}/usr/include/freetype2"
LDFLAGS="-lfontconfig -lXft -lXinerama -lX11 -lImlib2"

Perhaps @ericonr can weigh in.

@natrys natrys changed the title New package: xnotify-0.5.0 New package: xnotify-0.8.1 Apr 28, 2021
@ericonr
Copy link
Member

ericonr commented Apr 28, 2021

It avoids having to specify LDFLAGS yourself, at least

@natrys
Copy link
Contributor Author

natrys commented Apr 28, 2021

Fair enough, changed to that.

@github-actions
Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Apr 19, 2022
@natrys natrys closed this Apr 19, 2022
@natrys natrys deleted the xnotify-0.3.1 branch April 19, 2022 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants