Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common/shlib: bump neatvnc shlib #25190

Closed
wants to merge 1 commit into from

Conversation

jony255
Copy link
Contributor

@jony255 jony255 commented Sep 29, 2020

Should've done this in my previous pr

@Chocimier
Copy link
Member

Entry in shlibs states minimal version of package that provides solib fulfilling requirements of consumers of solib. Usually if solib version is same, there is no need to modify shlibs. Exceptions exists, one of them is when upstream didn't increased solib despite of being incompatble, other is when updated solib provides symbols that are consumed by other packages.
If such exception is case here, you need to revbump consumers in this PR too, because building consumers is when information in shlib is actually used to set minimal required version of dependency in consumer package.

@jony255
Copy link
Contributor Author

jony255 commented Sep 29, 2020

Ooh I see. This cleared up some misconceptions I had. I appreciate it! :)

@jony255 jony255 closed this Sep 29, 2020
@jony255 jony255 deleted the neatvnc-shlibs branch September 29, 2020 19:35
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants