Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: deno-1.5.3 #25436

Closed
wants to merge 1 commit into from
Closed

New package: deno-1.5.3 #25436

wants to merge 1 commit into from

Conversation

shizonic
Copy link
Contributor

@shizonic shizonic commented Oct 8, 2020

No description provided.

@shizonic shizonic changed the title New package: deno-1.4.4 WIP: New package: deno-1.4.4 Oct 8, 2020
srcpkgs/deno/template Outdated Show resolved Hide resolved
@Chocimier
Copy link
Member

Are problems from #22043 addressed in this release?

@shizonic
Copy link
Contributor Author

shizonic commented Oct 9, 2020

No they aren't. I can't figure out where exactly the binaries are fetched.

@shizonic shizonic changed the title WIP: New package: deno-1.4.4 [WIP] New package: deno-1.4.5 Oct 9, 2020
@shizonic shizonic changed the title [WIP] New package: deno-1.4.5 [WIP] New package: deno-1.4.6 Oct 13, 2020
@shizonic
Copy link
Contributor Author

I really don't know why it always runs out of time. It builds successfully on my local machine. Any suggestions?

@Chocimier
Copy link
Member

Disabling arm following upstream suggestion is acceptable, but limiting to single arch due to precompiled components is not.

I really don't know why it always runs out of time.

See linked PR.

@shizonic
Copy link
Contributor Author

shizonic commented Oct 14, 2020

but limiting to single arch due to precompiled components is not.

It's not because of that, it's because x64_86 is currently the only supported arch. See: denoland/deno#7958 (comment)

But I appreciate any help!

@ericonr
Copy link
Member

ericonr commented Oct 14, 2020

You might need to package GN in void, I think (ew). See here, I think the env var is just GN.

@shizonic
Copy link
Contributor Author

@ericonr Thanks! What should the content of the env var GN be? The path to the gn binary?

@shizonic
Copy link
Contributor Author

Waiting for merge of #25703

@q66
Copy link
Contributor

q66 commented Nov 16, 2020

it's come to my attention that gn is unstable, so it probably doesn't make sense to have a separate package of it; i'd just fetch it as a second distfile in the deno template and build it as a part of it

@shizonic shizonic changed the title New package: deno-1.5.2 New package: deno-1.5.3 Nov 18, 2020
@smorimoto
Copy link
Contributor

The CIs should complete successfully, but the GitHub Actions runner is somehow hung and needs to be triggered again.

@smorimoto
Copy link
Contributor

Oh disregard. It looks like it's still running.

@shizonic
Copy link
Contributor Author

Oh disregard. It looks like it's still running.

Yes, build process needs terribly long...

@shizonic
Copy link
Contributor Author

builds now fine on x86_64. Other archs aren't supported yet...

@smorimoto
Copy link
Contributor

Checks have passed.

@shizonic
Copy link
Contributor Author

Checks have passed.

Not at all: travis-ci still failes even if I don't understand why these checks are still present.

@smorimoto
Copy link
Contributor

Well, I think we can ignore the result of Travis.

@shizonic
Copy link
Contributor Author

Well, I think we can ignore the result of Travis.

Agree but guess it still won't get merged because it's only for x86_64 arch... :(

@shizonic
Copy link
Contributor Author

shizonic commented Nov 22, 2020

Is there a chance to get this merged?

@q66
Copy link
Contributor

q66 commented Nov 22, 2020

only if it can do musl and/or other archs imo

@smorimoto
Copy link
Contributor

​I think there is no reason why we cannot support all of them. (​In fact, I built and used Deno on aarch64 machines.)

@q66
Copy link
Contributor

q66 commented Nov 22, 2020

definitely not all of them, i just ran a ppc64le build out of curiosity and it fails on ring which seems to be a hard dependency and practically restricts the whole thing to x86_64 and possibly aarch64

@shizonic
Copy link
Contributor Author

Okay, to do so I need help. I only get it building on x86_64 and AFAIK officially it's only supported on this too.

@ericonr ericonr added the new-package This PR adds a new package label Dec 20, 2020
@astralchan
Copy link
Contributor

astralchan commented May 31, 2021

Even if it's not officially supported, it's probably worth trying to build it as a target. As for how to test against other archs locally, xbps-src has an -a flag. You can ./xbps-src -a x86_64-musl pkg deno if you wanted to test, for example.

I just read the conversation, and, uhh. I wonder why not just use build_style=cargo? Does it not work? Here's the PKGBUILD from Arch linux.

@Chocimier
Copy link
Member

You can ./xbps-src -a x86_64-musl pkg deno if you wanted to test, for example.

That's not what builders do. -a is for other processor. For other libc separate masterdir is better, see readme.

I wonder why not just use build_style=cargo? Does it not work?

Try and tell us.

@github-actions
Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants