projectM: fix GUI applications for cross. #25502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The template had a note: `TODO: find out why these files aren't generated for the cross build`, regarding the desktop files and icons that weren't being installed. This was actually because the GUI application's weren't being built at all! The build system could not find QT. Force enabling these applications and doing qt shenanigans, including `build_helper=qmake`, fixes these issues.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The template had a note:
TODO: find out why these files aren't generated for the cross build,regarding the desktop files and icons that weren't being installed.
This was actually because the GUI application's weren't being built
at all! The build system could not find QT. Force enabling these
applications and doing qt shenanigans, including
build_helper=qmake,fixes these issues.