synapse: update to 1.21.2. #25592
Merged
synapse: update to 1.21.2. #25592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freshprince
force-pushed
the
synapse-1.21.1
branch
from
2c5b7a2
to
bd0880f
Compare
ahesford
requested changes
Oct 21, 2020
There was a problem hiding this comment.
We tend to ignore version restrictions on python packages unless there is a tight coupling between the packages. Also, restrictions in these templates are not consistent. Upstream synapse restricts versions on every package in install_requires, but only python3-canonicaljson is restricted here.
Please drop version restrictions in both templates. Also, please confirm that python3-six is necessary for python3-canonicaljson. I see no mention of it in the upstream install_requires.
freshprince
force-pushed
the
synapse-1.21.1
branch
from
bd0880f
to
35a7bc9
Compare
|
Thanks for taking a look. I removed the version restrictions and tested whether |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.