Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gyazo: update to 1.3.1. #25639

Closed
wants to merge 1 commit into from
Closed

gyazo: update to 1.3.1. #25639

wants to merge 1 commit into from

Conversation

nielznl
Copy link
Contributor

@nielznl nielznl commented Oct 15, 2020

No description provided.

ahesford
ahesford requested changes Oct 20, 2020
View reviewed changes
srcpkgs/gyazo/template Outdated Show resolved Hide resolved
ericonr
ericonr reviewed Oct 20, 2020
View reviewed changes
srcpkgs/gyazo/template Outdated Show resolved Hide resolved
@nielznl nielznl closed this Nov 7, 2020
@ericonr
Copy link
Member

ericonr commented Nov 7, 2020

Is this PR no longer valid?

@nielznl
Copy link
Contributor Author

nielznl commented Nov 7, 2020

Is this PR no longer valid?

Well, I was trying to contribute and thought I would start out with a version bump but didn't know how to deal with the users.noreply.github.com maintainer email

@ericonr
Copy link
Member

ericonr commented Nov 7, 2020 •
edited

The changes look ok. Maintaining a package usually just means that your opinion might have more weight on some conversation about the package, and you might be mentioned in issues about it. Some people are known to shoot emails at maintainers, as well :)

Feel free to ping maintainers, there are a lot of PRs and it's easy to miss them. And I think you should reopen this one, if you want c:

@nielznl
Copy link
Contributor Author

nielznl commented Nov 7, 2020

The changes look ok. Maintaining a package usually just means that your opinion might have more weight on some conversation about the package, and you might be mentioned in issues about it. Some people are known to shoot emails at maintainers, as well :)

Feel free to ping maintainers, there are a lot of PRs and it's easy to miss them. And I think you should reopen this one, if you want c:

Thank you for the clarification! I shouldn't have removed my fork tho, now I can not reopen this pull request. I will open a new pull request, I hope it isn't too big of a deal.

@nielznl nielznl mentioned this pull request Nov 8, 2020
Merged
@ericonr
Copy link
Member

ericonr commented Nov 8, 2020

Not ideal, but it's a limitation of GH.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DirectorX DirectorX DirectorX left review comments

@ericonr ericonr ericonr left review comments

@ahesford ahesford ahesford requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nielznl @ericonr @DirectorX @ahesford