Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

krita: update to 4.4.0. #25651

Merged
merged 2 commits into from Oct 22, 2020
Merged

krita: update to 4.4.0. #25651

merged 2 commits into from Oct 22, 2020

Conversation

kartikynwa
Copy link
Contributor

I have built both packages and can confirm they work perfectly at least for x86_64. The SeExpr module for Krita is working as well.

Should I test cross-building for seexpr-krita? I can't do it for krita cuz my computer is slow but can test the seexpr-krita if needed.

Johnnynator
Johnnynator requested changes Oct 18, 2020
View reviewed changes
Copy link
Member

@Johnnynator Johnnynator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seexpr doesn't cross compile ootb, either try to fix it or set it nocross and make the dep in krita conditional.

srcpkgs/seexpr-krita/template Outdated Show resolved Hide resolved
srcpkgs/seexpr-krita/template Show resolved Hide resolved
srcpkgs/seexpr-krita/template Outdated Show resolved Hide resolved
@kartikynwa
Copy link
Contributor Author

kartikynwa commented Oct 18, 2020 •
edited

@Johnnynator I tried cross-building seexpr-krita for aarch64-musl. Many of the errors were fixed by moving the makedepends to hostmakedepends. This is the template I have now. But I get this error now that I don't have any idea about. Any pointers?

@kartikynwa
Copy link
Contributor Author

@Johnnynator I put the -DUSE_PYTHON=OFF flag in seexpr-krita. It can now be cross-built (tested with armv6l-musl and armv7) and still has full functionality with krita.

@Johnnynator Johnnynator merged commit b48932c into void-linux:master Oct 22, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2021
@kartikynwa kartikynwa deleted the krita-update branch May 24, 2021 15:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Johnnynator Johnnynator Johnnynator requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kartikynwa @Johnnynator