ffms2: update to 2.40. #25850
Closed
ffms2: update to 2.40. #25850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DirectorX
force-pushed
the
ffms2
branch
3 times, most recently
from
b8b04cc
to
7b5108a
Compare
Closed
|
Hi! Could you please look at the build failures? It's possible that rebasing and force pushing, to trigger a build on the new CI, will be enough. |
DirectorX
force-pushed
the
ffms2
branch
6 times, most recently
from
4cb986a
to
17fdd62
Compare
|
ping @ericonr |
ericonr
reviewed
Dec 20, 2020
srcpkgs/ffms2/template
Outdated
Comment on lines
16
to
18
| case "$XBPS_TARGET_MACHINE" in | ||
| armv6l-musl) broken="https://github.com/void-linux/void-packages/runs/1584330257?check_suite_focus=true";; | ||
| esac |
There was a problem hiding this comment.
It isn't fine to stop building the package for a target, since it has dependants.
The issue here is the lack of libatomic-devel. It might be enough to add
if [ "$XBPS_TARGET_NO_ATOMIC8" ]; then
makedepends+=" libatomic-devel"
fi
to the template.
There was a problem hiding this comment.
Otherwise, try adding LDFLAGS="-latomic" as well.
|
@ericonr done |
|
I fixed it to use |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.