New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qalculate, qalculate-gtk: update to 3.14.0, drop noarch. #25872
Conversation
99a7265
to
fac76b8
Compare
|
||
libqalculate-data_package() { | ||
archs=noarch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the dropping of noarch
, there is no need to have a separate data
subpackage. Please drop this package entirely, moving its contents to the libqalculate
subpackage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how to do this without hurting any existing installations. I added my attempt in a commit to this PR. In my case, the package upgrade went smoothly, but deleting the old libqalculate-data
package resulted in deletion of the files which are now a part of libqalculate
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I just found out about replaces
and it worked. Commit updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remember to remove the symlink.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the revision
and squash commits 26c9675 and 206eee8, so there is exactly one commit for the qalculate
changes and one for the qalculate-gtk
changes.
srcpkgs/qalculate/template
Outdated
version=3.12.1 | ||
revision=1 | ||
version=3.14.0 | ||
revision=2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should still have revision=1
Closes: void-linux#25872 [via git-merge-pr]
No description provided.