Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qalculate, qalculate-gtk: update to 3.14.0, drop noarch. #25872

Closed
wants to merge 2 commits into from

Conversation

ashpool37
Copy link
Contributor

No description provided.

@ashpool37 ashpool37 changed the title qalculate, qalculate-gtk: update to 3.13.0. qalculate, qalculate-gtk: update to 3.13.0, drop noarch. Oct 25, 2020
@ashpool37 ashpool37 changed the title qalculate, qalculate-gtk: update to 3.13.0, drop noarch. qalculate, qalculate-gtk: update to 3.14.0, drop noarch. Oct 26, 2020

libqalculate-data_package() {
archs=noarch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the dropping of noarch, there is no need to have a separate data subpackage. Please drop this package entirely, moving its contents to the libqalculate subpackage.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how to do this without hurting any existing installations. I added my attempt in a commit to this PR. In my case, the package upgrade went smoothly, but deleting the old libqalculate-data package resulted in deletion of the files which are now a part of libqalculate.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I just found out about replaces and it worked. Commit updated.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to remove the symlink.

Copy link
Member

@ahesford ahesford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the revision and squash commits 26c9675 and 206eee8, so there is exactly one commit for the qalculate changes and one for the qalculate-gtk changes.

version=3.12.1
revision=1
version=3.14.0
revision=2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should still have revision=1

@ahesford ahesford closed this in 7daac07 Oct 29, 2020
@ashpool37 ashpool37 deleted the qalc branch October 29, 2020 17:08
Logarithmus pushed a commit to Logarithmus/void-packages that referenced this pull request Nov 15, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants