azote: update to 1.8.1 #25903
azote: update to 1.8.1 #25903
Conversation
srcpkgs/azote/template
Outdated
| version=1.7.10 | ||
| revision=2 | ||
| version=1.8.1 | ||
| revision=1 | ||
| build_style=python3-module | ||
| hostmakedepends="python3-setuptools" | ||
| depends="python3>=3.4 python3-setuptools python3-gobject python3-Pillow gtk+3 feh python3-send2trash xrandr grim slurp ImageMagick python3-yaml" |
There was a problem hiding this comment.
Please drop the following packages from the dependencies:
- xrandr
- feh
- python3-send2trash
- grim
- slurp
- ImageMagick
- python3-yaml
- python3-setuptools
All but the last enable optional functionality, and the program itself provides a warning about missing packages and disabled functionality when users run without these packages installed. There is no need to pull in everything by force, especially the xrandr dependency for Wayland users, or the grim and slurp dependencies for Xorg users.
The last dependency is strictly wrong, as setuptools is not needed anywhere for runtime operation of azote.
There was a problem hiding this comment.
Well, azote uses pkg_resources module from setuptools.
There was a problem hiding this comment.
My mistake, python3-setuptools definitely belongs in depends because of pkg_resources. Thanks @Chocimier.
This means python3 can just be dropped, because python3-setuptools already pulls that in.
There was a problem hiding this comment.
Updated, thanks @Chocimier and @ahesford!
ghost
requested a review
from 
srcpkgs/azote/template
Outdated
| build_style=python3-module | ||
| hostmakedepends="python3-setuptools" | ||
| depends="python3>=3.4 python3-setuptools python3-gobject python3-Pillow gtk+3 feh python3-send2trash xrandr grim slurp ImageMagick python3-yaml" | ||
| depends="python3>=3.4 python3-gobject python3-Pillow gtk+3" |
There was a problem hiding this comment.
Please drop >=3.4, it's too old to work with like anything.
There was a problem hiding this comment.
Replaced python3 with python3-setuptools
srcpkgs/azote/template
Outdated
|
|
||
| post_install() { | ||
| vmkdir usr/bin | ||
| vmkdir usr/share/${pkgname} | ||
| vmkdir usr/share/applications | ||
|
|
||
| vcopy "dist/${pkgname}.svg" usr/share/${pkgname} | ||
| vcopy "dist/${pkgname}-arch" usr/share/${pkgname} | ||
| vcopy "dist/${pkgname}" usr/share/${pkgname} |
There was a problem hiding this comment.
There's no value in copying this script to usr/share and then symlinking to it from usr/bin, just vcopy right into usr/bin and drop the symlink in line 26.
Closes: void-linux#25903 [via git-merge-pr]
https://github.com/nwg-piotr/azote/releases/tag/v1.8.1