Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libsndfile: use python3 when building #26023

Merged
merged 1 commit into from Nov 6, 2020
Merged

libsndfile: use python3 when building #26023

merged 1 commit into from Nov 6, 2020

Conversation

lun-4
Copy link
Contributor

@lun-4 lun-4 commented Oct 31, 2020 •
edited

  • Use python3 as it's compatible (see Upgrade to Python 3 libsndfile/libsndfile#490)
  • Noticed the repository moved to its own organization. Update homepage and distfiles to keep it in sync.
    • The old distfiles url still redirects and the given .tar.bz2 file from it has matching hashes, so checksum didn't update.

ericonr
ericonr requested changes Oct 31, 2020
View reviewed changes
srcpkgs/libsndfile/template Outdated Show resolved Hide resolved
@lun-4 lun-4 force-pushed the libsndfile-update-links branch 2 times, most recently from b3e6e96 to 7fc1e8d Compare October 31, 2020 21:13
@biopsin
Copy link
Contributor

biopsin commented Nov 1, 2020

what about bump to python3 ?
libsndfile/libsndfile#490

@lun-4
Copy link
Contributor Author

lun-4 commented Nov 1, 2020

I think a python3 bump would be better in a separate PR.

@ericonr
Copy link
Member

ericonr commented Nov 1, 2020

I think a python3 bump would be better in a separate PR.

Your choice, really. The link fixes are routine maintenance, but you can repurpose the PR and just include the fixes together with the rest.

@lun-4 lun-4 changed the title libsndfile: update homepage and distfiles libsndfile: use python3 when building Nov 2, 2020
@lun-4 lun-4 requested a review from ericonr November 2, 2020 03:35
@ericonr
Copy link
Member

ericonr commented Nov 6, 2020

Does it need to be revbumped?

@lun-4
Copy link
Contributor Author

lun-4 commented Nov 6, 2020

I didn't read the Manual.md section on revisions and had a wrong definition in my mind. I kept the package on the old revision.

@ericonr
Copy link
Member

ericonr commented Nov 6, 2020

Great. thanks!

@ericonr ericonr merged commit fc749c3 into void-linux:master Nov 6, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ericonr ericonr Awaiting requested review from ericonr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lun-4 @biopsin @ericonr