Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ardour: add pulseaudio backend #26135

Closed
wants to merge 1 commit into from
Closed

ardour: add pulseaudio backend #26135

wants to merge 1 commit into from

Conversation

krkk
Copy link
Contributor

@krkk krkk commented Nov 4, 2020

No description provided.

@krkk
Copy link
Contributor Author

krkk commented Nov 5, 2020

uhhh while the patch overall does its job, closing the app with this backend freezes itself, which isn't so great (x86_64-musl). :(

can be closed it if that isn't okay with you.

@ericonr
Copy link
Member

ericonr commented Nov 5, 2020

closing the app with this backend freezes itself, which isn't so great (x86_64-musl).

Might be an issue with how it interacts with musl; PA has some design choices that may depend on glibc behaviors. Does it still freeze if you don't use the backend, and it's only been compiled in?

@krkk
Copy link
Contributor Author

krkk commented Nov 5, 2020

Does it still freeze if you don't use the backend, and it's only been compiled in?

No, it doesn't freeze with alsa

@ericonr
Copy link
Member

ericonr commented Dec 20, 2020

I guess when you have pulseaudio running and use the alsa backend, it runs alsa through pulse anyway? Which wouldn't have locking issues.

@ericonr
Copy link
Member

ericonr commented Dec 20, 2020

If you think you should go on with the PR, please fix the download location to use https://github.com/Ardour/ardour/ ; they delete old tarballs.

@krkk
Copy link
Contributor Author

krkk commented Dec 20, 2020

I guess when you have pulseaudio running and use the alsa backend, it runs alsa through pulse anyway? Which wouldn't have locking issues.

Well, running ardour with alsa backend does lock pulse at my machine.

If you think you should go on with the PR, please fix the download location to use https://github.com/Ardour/ardour/ ; they delete old tarballs.

they also exclude everything from tarballs – the only thing that's shipped inside is README-GITHUB.txt.

@ericonr
Copy link
Member

ericonr commented Dec 20, 2020

If you have an account in their bug tracker, could you complain about that? It'd be okay if they at least provided tarballs for all releases, but given that they remove old ones...

@krkk
Copy link
Contributor Author

krkk commented Dec 24, 2020 via email

@ericonr
Copy link
Member

ericonr commented Dec 24, 2020

No problem. If you still use the software, we can perhaps repurpose this PR to update it to 6.5 :)

Otherwise, there's a chance the hang was caused by a very specific pattern, and might be solved in Musl 1.2.2. We can revisit enabling pulse then. Or you can make it an off by default build option.

@ericonr
Copy link
Member

ericonr commented Jul 20, 2021

@krkk do you still have interest in pursuing this PR? I can send you a branch with newer musl for testing purposes, if you want.

@krkk
Copy link
Contributor Author

krkk commented Jul 20, 2021

I'm sorry, I don't. I no longer use musl and pulseaudio.

@krkk krkk closed this Jul 20, 2021
@ericonr
Copy link
Member

ericonr commented Jul 20, 2021

No worries :)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants