Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: randomx-1.1.8 #26148

Closed
wants to merge 1 commit into from
Closed

Conversation

kevcrumb
Copy link
Contributor

@kevcrumb kevcrumb commented Nov 5, 2020

randomx contains binaries for benchmarking a machine for RandomX algo
librandomx provides library for using the algo (for example from a mining software)

randomx provides library for using the algo (for example from a mining software)

@kevcrumb kevcrumb force-pushed the randomx branch 4 times, most recently from d5fa1df to f80f8d2 Compare November 25, 2020 15:46
@kevcrumb
Copy link
Contributor Author

kevcrumb commented Nov 25, 2020

Pkg should be good for inclusion.

@kevcrumb kevcrumb changed the title randomx: add package v1.1.8 and librandomx New package: randomx-1.1.8 Nov 25, 2020
ppc64le*) configure_args+=" -DARCH=ppc64le" ;;
ppc64*) configure_args+=" -DARCH=ppc64" ;;
ppc*) configure_args+=" -DARCH=ppc" ;;
# *) configure_args+=" -DARCH=native" ;;
Copy link
Contributor

@q66 q66 Nov 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace this with

	*) broken="unsupported architecture" ;;

@sgn
Copy link
Member

sgn commented Nov 25, 2020 via email

@q66
Copy link
Contributor

q66 commented Nov 25, 2020

oh yeah

you'll need to fill in dedicated lines for those

also why did you remove the ppc ones?

@kevcrumb
Copy link
Contributor Author

also why did you remove the ppc ones?

Had read your instruction like that.

I see Monero just sets default (https://github.com/void-linux/void-packages/blob/master/srcpkgs/monero/template#L37).

Pushed with explicit i686 & x86_64 now.

Comment on lines 24 to 29
i686*) configure_args+=" -DARCH=i686" ;;
mips*) configure_args+=" -DARCH=mipsr32 -DNO_AES=ON" ;;
ppc64le*) configure_args+=" -DARCH=ppc64le" ;;
ppc64*) configure_args+=" -DARCH=ppc64" ;;
ppc*) configure_args+=" -DARCH=ppc" ;;
x86_64*) configure_args+=" -DARCH=x86_64" ;;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix indentation

@q66
Copy link
Contributor

q66 commented Nov 25, 2020

Had read your instruction like that.

not really, i commented on just one line

what monero sets does not matter, it's wrong there too, since packages like to assume x86_64 and i686 won't be cross-compiled, we're fixing that

@ericonr ericonr added the new-package This PR adds a new package label Dec 20, 2020
@github-actions
Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Apr 24, 2022
@github-actions github-actions bot closed this May 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants