-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: randomx-1.1.8 #26148
New package: randomx-1.1.8 #26148
Conversation
d5fa1df
to
f80f8d2
Compare
Pkg should be good for inclusion. |
srcpkgs/randomx/template
Outdated
ppc64le*) configure_args+=" -DARCH=ppc64le" ;; | ||
ppc64*) configure_args+=" -DARCH=ppc64" ;; | ||
ppc*) configure_args+=" -DARCH=ppc" ;; | ||
# *) configure_args+=" -DARCH=native" ;; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replace this with
*) broken="unsupported architecture" ;;
On 2020-11-25 07:57:25-0800, Daniel Kolesa ***@***.***> wrote:
@q66 commented on this pull request.
> +
+if [ "$XBPS_TARGET_NO_ATOMIC8" ]; then
+ makedepends+=" libatomic-devel"
+ configure_args+=" -DCMAKE_CXX_STANDARD_LIBRARIES=-latomic"
+fi
+
+case "$XBPS_TARGET_MACHINE" in
+ armv7*) configure_args+=" -DARCH=armv7" ;;
+ armv6*) configure_args+=" -DARCH=armv6" ;;
+ armv5*) configure_args+=" -DARCH=armv5" ;;
+ aarch64*) configure_args+=" -DARCH=aarch64" ;;
+ mips*) configure_args+=" -DARCH=mipsr32 -DNO_AES=ON" ;;
+ ppc64le*) configure_args+=" -DARCH=ppc64le" ;;
+ ppc64*) configure_args+=" -DARCH=ppc64" ;;
+ ppc*) configure_args+=" -DARCH=ppc" ;;
+# *) configure_args+=" -DARCH=native" ;;
replace this with
```
*) broken="unsupported architecture" ;;
```
Doesn't "*" include i686 and x86_64, which should be always supported?
|
oh yeah you'll need to fill in dedicated lines for those also why did you remove the ppc ones? |
Had read your instruction like that. I see Monero just sets Pushed with explicit |
srcpkgs/randomx/template
Outdated
i686*) configure_args+=" -DARCH=i686" ;; | ||
mips*) configure_args+=" -DARCH=mipsr32 -DNO_AES=ON" ;; | ||
ppc64le*) configure_args+=" -DARCH=ppc64le" ;; | ||
ppc64*) configure_args+=" -DARCH=ppc64" ;; | ||
ppc*) configure_args+=" -DARCH=ppc" ;; | ||
x86_64*) configure_args+=" -DARCH=x86_64" ;; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix indentation
not really, i commented on just one line what monero sets does not matter, it's wrong there too, since packages like to assume |
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it. |
randomx contains binaries for benchmarking a machine for RandomX algolibrandomx provides library for using the algo (for example from a mining software)randomx provides library for using the algo (for example from a mining software)