Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New package: neovim-gtk-0.2.0 #26283

Closed
wants to merge 1 commit into from
Closed

New package: neovim-gtk-0.2.0 #26283

wants to merge 1 commit into from

Conversation

folliehiyuki
Copy link
Contributor

ericonr
ericonr reviewed Nov 11, 2020
View reviewed changes
srcpkgs/neovim-gtk/template Outdated
checksum=df4567bc687074e085b16199cd63edd0b19c12a3d66721f8c2c6021e709f3a21

post_install() {
vinstall ${wrksrc}/desktop/org.daa.NeovimGtk.desktop 644 usr/share/applications
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use https://github.com/daa84/neovim-gtk/blob/master/Makefile#L15 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It uses /usr/local by defaut.
I will rewrite now, since I saw --prefix=/usr already there in configure_args.
My bad for not reading things through.

@folliehiyuki folliehiyuki force-pushed the neovim-gtk branch 3 times, most recently from b1018bc to 0099b07 Compare November 16, 2020 12:16
@folliehiyuki
Copy link
Contributor Author

I don't know why it fails on arm builds.

As some issues suggested I tried putting glib-devel into hostmakedepends but the builds still fail. Or am I doing it wrong?

@folliehiyuki folliehiyuki mentioned this pull request Dec 11, 2020
Merged
@ericonr
Copy link
Member

ericonr commented Dec 12, 2020

You want to use the cargo build style here, if at all possible. If not, at least add the rust build helper.

What you're missing is rust-std in makedepends.

@folliehiyuki
Copy link
Contributor Author

folliehiyuki commented Dec 12, 2020 •
edited

I misunderstood your 1st comment :)

Reverted it back to cargo build style.

EDIT: the resources still seems to not be installed correctly

@ericonr
Copy link
Member

ericonr commented Dec 14, 2020

EDIT: the resources still seems to not be installed correctly

You need to pass DESTDIR and PREFIX to the make invocation :) Otherwise it's installing those files in your masterdir

@folliehiyuki
Copy link
Contributor Author

Thanks for all the help. Fixed

@ericonr ericonr added the new-package This PR adds a new package label Dec 20, 2020
@folliehiyuki
Copy link
Contributor Author

I will close this as the terminal neovim is more preferable for me and I started using this application less. The template works fine on my machine (x86-64-musl). If someone else is interested feel free to take over.

@folliehiyuki folliehiyuki deleted the neovim-gtk branch January 16, 2021 13:44
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ericonr ericonr ericonr left review comments

Assignees
No one assigned
Labels
new-package This PR adds a new package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@folliehiyuki @ericonr