-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: whdd-3.0.1 #26339
New package: whdd-3.0.1 #26339
Conversation
c0f9bc5
to
028a383
Compare
Any idea how to fix that? UPD: Adding |
3449a54
to
43f42b3
Compare
@ndowens it works, GitHub Actions built successfully, but Travis hangs for no reason. |
67a1d59
to
63ce50d
Compare
Something nasty happens to the CI: https://github.com/void-linux/void-packages/pull/26339/checks?check_run_id=1932367887 |
54ca1ed
to
0bf074c
Compare
CI fails:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I restarted CI, so it completed fine.
c2233f5
to
75f2307
Compare
@ericonr it happened again |
The CI failures are probably just the server limiting us :p |
@ericonr what should I do in order to get this PR accepted? The rate-limiting thing still stands in our way. |
srcpkgs/dialog/template
Outdated
configure_args="LIBTOOL=${XBPS_CROSS_BASE}/usr/bin/libtool | ||
--with-ncursesw --with-libtool --disable-nls" | ||
make_build_args="LIBTOOL=${XBPS_CROSS_BASE}/usr/bin/libtool" | ||
make_install_args="LIBTOOL=${XBPS_CROSS_BASE}/usr/bin/libtool" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not in love with the LIBTOOL
part, was it fully necessary? What errors did you get?
Also, please create a _libtool=
variable to avoid repeating the path multiple times.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ericonr me too, but I've tried different options without much luck.
See #26339 (comment) and other comments in this PR for more context.
I've created _libtool
variable to avoid duplication.
6aed993
to
78f3f51
Compare
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it. |
HDD diagnostics and data recovery tool for Linux.
This PR also fixes
dialog
package, which is needed forwhdd
. Also it addslibdialog
intocommon/shlibs
.