Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: whdd-3.0.1 #26339

Closed
wants to merge 2 commits into from
Closed

Conversation

Logarithmus
Copy link
Contributor

@Logarithmus Logarithmus commented Nov 13, 2020

HDD diagnostics and data recovery tool for Linux.
This PR also fixes dialog package, which is needed for whdd. Also it adds libdialog into common/shlibs.

srcpkgs/dialog/template Outdated Show resolved Hide resolved
srcpkgs/dialog/template Outdated Show resolved Hide resolved
@Logarithmus
Copy link
Contributor Author

Logarithmus commented Nov 20, 2020

/usr/bin/ld: .libs/trace.o: Relocations in generic ELF (EM: 183)
/usr/bin/ld: .libs/trace.o: Relocations in generic ELF (EM: 183)
/usr/bin/ld: .libs/trace.o: error adding symbols: file in wrong format
collect2: error: ld returned 1 exit status
make: *** [makefile:378: libdialog.la] Error 1
make: *** Waiting for unfinished jobs....
=> ERROR: dialog-1.3.20200327_2: do_build: '${make_cmd} ${makejobs} ${make_build_args} ${make_build_target}' exited with 2
=> ERROR:   in do_build() at common/build-style/gnu-configure.sh:13

Any idea how to fix that?

UPD: Adding LIBTOOL=${XBPS_CROSS_BASE}/usr/bin/libtool to configure_args, make_build_args & make_install_args seems to fix it.

@Logarithmus
Copy link
Contributor Author

@ndowens it works, GitHub Actions built successfully, but Travis hangs for no reason.

@Logarithmus
Copy link
Contributor Author

Logarithmus commented Feb 19, 2021

Something nasty happens to the CI: https://github.com/void-linux/void-packages/pull/26339/checks?check_run_id=1932367887
Any ideas how to solve this?

@Logarithmus Logarithmus changed the title New package: whdd-3.0 New package: whdd-3.0.1 Feb 19, 2021
@Logarithmus
Copy link
Contributor Author

CI fails:

=> dialog-1.3.20210117_2: fetching distfile 'dialog-1.3-20210117.tgz'...
https://invisible-mirror.net/archives/dialog/dialog-1.3-20210117.tgz: Connection timed out
=> ERROR: dialog-1.3.20210117_2: failed to fetch dialog-1.3-20210117.tgz.
Error: Process completed with exit code 1.

@ndowens @ericonr, I need help with it.

Copy link
Member

@ericonr ericonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I restarted CI, so it completed fine.

srcpkgs/whdd/patches/gnu-source.patch Outdated Show resolved Hide resolved
srcpkgs/dialog/template Outdated Show resolved Hide resolved
srcpkgs/dialog/template Outdated Show resolved Hide resolved
common/shlibs Outdated Show resolved Hide resolved
@Logarithmus
Copy link
Contributor Author

I restarted CI, so it completed fine.

@ericonr it happened again

@ericonr
Copy link
Member

ericonr commented Feb 21, 2021

The CI failures are probably just the server limiting us :p

@Logarithmus
Copy link
Contributor Author

Logarithmus commented Mar 26, 2021

@ericonr what should I do in order to get this PR accepted? The rate-limiting thing still stands in our way.

Comment on lines 9 to 12
configure_args="LIBTOOL=${XBPS_CROSS_BASE}/usr/bin/libtool
--with-ncursesw --with-libtool --disable-nls"
make_build_args="LIBTOOL=${XBPS_CROSS_BASE}/usr/bin/libtool"
make_install_args="LIBTOOL=${XBPS_CROSS_BASE}/usr/bin/libtool"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not in love with the LIBTOOL part, was it fully necessary? What errors did you get?

Also, please create a _libtool= variable to avoid repeating the path multiple times.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ericonr me too, but I've tried different options without much luck.
See #26339 (comment) and other comments in this PR for more context.
I've created _libtool variable to avoid duplication.

@github-actions
Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Apr 28, 2022
@github-actions github-actions bot closed this May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants