Go package clean up #26377
Go package clean up #26377
Conversation
ericonr
force-pushed
the
gorebuild
branch
4 times, most recently
from
8a887c4
to
fc046c5
Compare
|
For |
srcpkgs/chronograf/template
Outdated
| @@ -18,6 +18,7 @@ system_accounts="_chronograf" | |||
| _chronograf_homedir="/var/lib/${pkgname}" | |||
| make_dirs="${_chronograf_homedir} 0755 _chronograf _chronograf" | |||
|
|
|||
| broken="fails to build v8: error: 'class Nan::Persistent<v8::Object>' has no member named 'IsNearDeath'" | |||
There was a problem hiding this comment.
Might be worth just switching to upstream assets if they vendor a tarball.
There was a problem hiding this comment.
Not sure this one is necessary anymore, since you merged the fix.
srcpkgs/goproxy/template
Outdated
| @@ -11,3 +11,4 @@ license="GPL-3.0-or-later" | |||
| homepage="https://github.com/snail007/goproxy" | |||
| distfiles="https://github.com/snail007/goproxy/archive/v${version}.tar.gz" | |||
| checksum=13f8e37d274d2b7b7cdf1ae3d98723fbb9acf1476c92a1e0d43039109d238ccc | |||
| broken="7.0 tag was removed from repository" | |||
There was a problem hiding this comment.
Reviewing the upstream licensing this whole project appears kind of shady. There is a v10.1 tag, is there a reason you did not use that instead of upgrading?
There was a problem hiding this comment.
By upgrading do you mean marking as broken?
I didn't want to update the package without having an idea of how it works / is supposed to work, and using a newer tag doesn't protect us from them dropping it in the future again. I'd consider dropping the package, if you think it makes sense.
srcpkgs/dnote-cli/template
Outdated
| wrksrc="cli-${version}" | ||
| wrksrc="dnote-${version}" |
There was a problem hiding this comment.
I would say this is worth to warrant a rebuild.
Thinking a bit more, there's something that was changed here. The distfiles is still the same but the extracted directory is different. Have you check if they have same source?
srcpkgs/gfuzz/template
Outdated
| version=0.2 | ||
| revision=1 | ||
| wrksrc="gfuzz-${version}" | ||
| wrksrc="gfz-${version}" |
srcpkgs/miniflux/template
Outdated
| @@ -2,6 +2,7 @@ | |||
| pkgname=miniflux | |||
| version=2.0.24 | |||
| revision=1 | |||
| wrksrc=v2-${version} | |||
There was a problem hiding this comment.
We need to diff the distfiles, and warrant a rebuild.
|
Thanks, I will investigate. |
|
@ericonr what's the status on this PR? |
Setting LDFLAGS="-fuse-ld=bfd" does no longer work. However all targets except ppc64le* support using the internal linker instead. I found no way to make the ppc64le* build work and left it trying to use the old method.
While I get ready to do a full go rebuild, I found packages with various issues. Some broken ones and some had changed paths.
ping @the-maldridge @thypon @Vaelatern @misuchiru03 @renatoaguiar @steinex @CameronNemo