Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: pcaudiolib-1.1 #26416

Merged
merged 1 commit into from
Dec 14, 2020
Merged

New package: pcaudiolib-1.1 #26416

merged 1 commit into from
Dec 14, 2020

Conversation

joey-commits
Copy link
Contributor

No description provided.

@joey-commits
Copy link
Contributor Author

Duplicate of 26384

@joey-commits
Copy link
Contributor Author

Original committer @skmpz asked me to reopen my pull request and closed theirs.

@joey-commits
Copy link
Contributor Author

I would appreciate feedback on whether I formatted the patches correctly. These fix some issues when espeakup is used with espeak-ng.

@joey-commits
Copy link
Contributor Author

Is there any chance that someone may have time to comment on this one? I desire to get this into the repos because then I can add espeak-ng which works better with the Orca and espeakup assistive technologies which I use frequently. Espeak-ng is also recently having a new Klatt synthesis functionality which is easier on some folks ears. If someone clears this, I will immediately resolve the conflicts in common/shlibs so the merge can take place.

}

pcaudiolib-devel_package() {
depends="pcaudiolib>=${version}_${revision}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
depends="pcaudiolib>=${version}_${revision}"
depends="${sourcepkg}>=${version}_${revision}"

pkgname=pcaudiolib
version=1.1
revision=1
wrksrc=${pkgname}-${version}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the default value for wrksrc.

@joey-commits
Copy link
Contributor Author

Thank you very much for the feedback. I have performed the suggested fixes.

@ericonr ericonr merged commit 6a1c24f into void-linux:master Dec 14, 2020
@ericonr
Copy link
Member

ericonr commented Dec 14, 2020

This will have to wait a while to appear on all systems, since chromium is currently being built.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants