New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: cryptomator-cli-0.4.0 #26438
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remember to squash your commits into a single one :)
srcpkgs/cryptomator-cli/template
Outdated
echo '#!/bin/sh | ||
MYSELF=$(which "$0" 2>/dev/null) | ||
[ $? -gt 0 -a -f "$0" ] && MYSELF="./$0" | ||
java=java | ||
if test -n "$JAVA_HOME"; then | ||
java="$JAVA_HOME/bin/java" | ||
fi | ||
exec "$java" $java_args -jar $MYSELF "$@" | ||
exit 1' > stub.sh | ||
cat stub.sh "${pkgname}-${version}.jar" > ${pkgname} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming I understood this correctly, you shouldn't do this, the preferred solution is to make a wrapper script in files/
and exec java -jar
in it.
Also, which
isn't installed by default, you can just use command -v
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I was thinking about something like that. I created the wrapper script to be put in /bin and I am now copying the jar file to /usr/share/${pkgname}.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought /usr/share/${pkgname} would be the right location
revision=1 | ||
wrksrc="cli-${version}" | ||
makedepends="apache-maven" | ||
depends="openjdk11 davfs2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it really openjdk11 or does it work with an earlier one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The readme says 'at least JDK 11'. It seems to be compiled for JDK 11 which was also mentioned in the error it gave me after running it with JDK 8.
I use this program myself, let me know whether it fits in the packages collection