Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nushell: update to 0.22.0, update distfile #26454

Closed
wants to merge 0 commits into from
Closed

nushell: update to 0.22.0, update distfile #26454

wants to merge 0 commits into from

Conversation

Rheydskey
Copy link

Hi,
I have updated nushell and changed the repositories of the compilation files.
Rheydskey

@Rheydskey Rheydskey changed the title Updated nushell and changed the source of the compilation file nushell: Updated to 0.22.0 and changed the source of the compilation file Nov 17, 2020
@Rheydskey Rheydskey changed the title nushell: Updated to 0.22.0 and changed the source of the compilation file nushell: update to 0.22.0 and changed the source of the compilation file Nov 17, 2020
revision=1
# raw-cpuid does not support other archs
# https://github.com/nushell/nushell/issues/485
# remove when the issue is fixed (should fix all archs)
archs="x86_64* i686*"
wrksrc="nu-${version}"
wrksrc="nushell-${version}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's default, you can just remove the line.

@ericonr
Copy link
Member

ericonr commented Nov 17, 2020

Please follow commit style properly: nushell: update to 0.22.0, update distfile

That said, why move to github instead of continuing using crates?

@Rheydskey Rheydskey changed the title nushell: update to 0.22.0 and changed the source of the compilation file nushell: nushell: update to 0.22.0, update distfile Nov 17, 2020
@Rheydskey Rheydskey changed the title nushell: nushell: update to 0.22.0, update distfile nushell: update to 0.22.0, update distfile Nov 17, 2020
@Rheydskey
Copy link
Author

Please follow commit style properly: nushell: update to 0.22.0, update distfile

That said, why move to github instead of continuing using crates?

I switched to github because using firefox I couldn't download the source archive. So I thought that with wget or curl (I don't know what xbps uses) the archive wouldn't download either.

@ericonr
Copy link
Member

ericonr commented Nov 17, 2020

It might have changed to nushell/nushell-$version, but eh. Fetching from github works.

@ericonr
Copy link
Member

ericonr commented Nov 17, 2020

You updated PR title, but I need you to update the commit message :)

You should also squash the commits, ideally we want a single commit per package.

@ericonr
Copy link
Member

ericonr commented Nov 17, 2020

It seems you'll have to wait for rust 1.47 to be packaged, because nushell requires nightly features such as a new constant.

@Rheydskey
Copy link
Author

It seems you'll have to wait for rust 1.47 to be packaged, because nushell requires nightly features such as a new constant.

Yes

@ericonr
Copy link
Member

ericonr commented Nov 26, 2020

You updated PR title, but I need you to update the commit message :)

You should also squash the commits, we want a single commit per package.

@Rheydskey
Copy link
Author

You updated PR title, but I need you to update the commit message :)

You should also squash the commits, we want a single commit per package.

How I do it ?

@ericonr
Copy link
Member

ericonr commented Nov 26, 2020

https://git-rebase.io/ is one guide for it. Just use interactive rebase, mark the last commit to squash it, and fix the message. Then force push to the branch.

@Rheydskey
Copy link
Author

https://git-rebase.io/ is one guide for it. Just use interactive rebase, mark the last commit to squash it, and fix the message. Then force push to the branch.

It's okay, I've done everything

@ericonr
Copy link
Member

ericonr commented Dec 20, 2020

Please update the PR, new Rust has been merged.

@ericonr
Copy link
Member

ericonr commented Dec 31, 2020

Please update to 0.24.1: https://github.com/nushell/nushell/releases

And see if you can fix the tests, I'm not sure why they fail.

Ping me when done, and a happy new year

@Rheydskey Rheydskey closed this Jan 2, 2021
@Rheydskey
Copy link
Author

I made a bad manipulation

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants