mpv: update to 0.33.0

[concatime]

No description provided.

[ericonr]

This should be a single commit, but the list of changes should be kept in the commit message :)

Also, :c for removed sndio support

[concatime]

@ericonr understood

Also, we should wait for #26670 before merging this.

[ericonr]

I'm going to see if a revert of mpv-player/mpv@71d218e builds, I really hate that they removed it :/

Edit: seems way more involved than I was expecting, they reworked a lot of stuff around it. I will see if I can get something going (might steal patches from OpenBSD), but this PR should proceed as is.

Edit2: You might want to get it to build with OpenAL, for the moment. It can interface with sndio.

[ericonr]

Would you mind pulling the libplacebo update into this PR? For things that depend on each other, it makes sense to update multiple packages in a single PR

[concatime]

I will add OpenAL tomorrow.

[q66]

don't use the OpenAL backend in mpv, it has massive issues and you're better off just using pulse, or if you really want to keep sndio, probably alsa-sndio + alsa ao would work

[ericonr]

AFAIK alsa-sndio has multiple sync issues, and OpenAL was the upstream recommendation when people complained about sndio being removed.

I don't see the issue with having the backend available.

[q66]

as far as i know, the openal backend is slow, experimental and severely broken with multichannel audio (and i don't see upstream ever recommending it anywhere)

there's a good reason it's disabled by the build system by default (even if openal is found on your system)

[concatime]

i don't see upstream ever recommending it anywhere

In commit removing OSS (mpv-player/mpv@bca917f):

Ancient Linux audio output. Apparently it survived until now, because
some BSDs (but not all) had use of this. But these should work with
ao_sdl or ao_openal too (that's why these AOs exist after all).

[concatime]

So, I added OpenAL as a build option, but not enabled by default.

[ericonr]

It might need atomic support with libatomic. Use XBPS_TARGET_NO_ATOMIC8 as a conditional for makedepends+=" libatomic-devel"... At least I think that's the issue

[concatime]

I merged #26670 and #26678 into this request, with the right order.

[ericonr]

For what it's worth, this is working. sndio might be added back next release, but i don't think this update should wait on a way forward for sndio being decided so we could add a patch for it.

[concatime]

up

[ericonr]

I'm waiting on feedback from others on patching sndio back, otherwise I can merge tomorrow morning.

Sorry for the delay.

[ericonr]

Thanks for working on this!

[stnby]

I happened to switch to sndio right after this commit. And got so confused by this https://docs.voidlinux.org/config/media/sndio.html#mpv I hope the support comes back as soon as possible. :)