-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: hunspell-ro_RO-3.3.10 #26799
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Be sure to squash your commits into a single one for the PR!
srcpkgs/hunspell-ro_RO/template
Outdated
version=3.3.10 | ||
revision=1 | ||
wrksrc=hunspell-ro.${version} | ||
short_desc="Romanian ro_RO dictionary for hunspell" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it need ro_RO
in the description?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really, I just saw that some other dictionaries had it and decided to add it. I suppose it's unnecessary.
(please fix the commit message as well) :) |
srcpkgs/hunspell-ro_RO/template
Outdated
maintainer="Klorophatu <klorophatu@krutt.org>" | ||
license="GPL-2.0-or-later, LGPL-2.1-or-later, MPL-1.1" | ||
homepage="https://sourceforge.net/projects/rospell/" | ||
distfiles="https://sourceforge.net/projects/rospell/files/Romanian%20dictionaries/dict-${version}/hunspell-ro.${version}.tar.gz" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have SOURCEFORGE_SITE
as a variable you can use for downloading stuff from sourceforge, do you think it's possible to plug it in here?
CI is having weird issues :/ Also, please ping me when you have made the requested changes :) |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If SOURCEFORGE_SITE
generates too many failures, feel free to use the previous link.
srcpkgs/hunspell-ro_RO/template
Outdated
create_wrksrc=yes | ||
hostmakedepends="unzip" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you add this? We use bsdtar
for zip files.
And I believe it was working without create_wrksrc
previously?
srcpkgs/hunspell-ro_RO/template
Outdated
vinstall ${wrksrc}/ro_RO.aff 644 /usr/share/hunspell | ||
vinstall ${wrksrc}/ro_RO.dic 644 /usr/share/hunspell | ||
vlicense ${wrksrc}/README |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure ${wrksrc}
should be required here...
Also, use usr/share/hunspell
.
Sourceforge keeps timing out, making the builds fail. EDIT: Seems to work now. |
No description provided.