Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: hunspell-ro_RO-3.3.10 #26799

Merged
merged 1 commit into from Dec 2, 2020
Merged

New package: hunspell-ro_RO-3.3.10 #26799

merged 1 commit into from Dec 2, 2020

Conversation

ghost
Copy link

@ghost ghost commented Nov 29, 2020

No description provided.

Copy link
Member

@ericonr ericonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be sure to squash your commits into a single one for the PR!

version=3.3.10
revision=1
wrksrc=hunspell-ro.${version}
short_desc="Romanian ro_RO dictionary for hunspell"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it need ro_RO in the description?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really, I just saw that some other dictionaries had it and decided to add it. I suppose it's unnecessary.

@ericonr
Copy link
Member

ericonr commented Dec 1, 2020

(please fix the commit message as well) :)

maintainer="Klorophatu <klorophatu@krutt.org>"
license="GPL-2.0-or-later, LGPL-2.1-or-later, MPL-1.1"
homepage="https://sourceforge.net/projects/rospell/"
distfiles="https://sourceforge.net/projects/rospell/files/Romanian%20dictionaries/dict-${version}/hunspell-ro.${version}.tar.gz"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have SOURCEFORGE_SITE as a variable you can use for downloading stuff from sourceforge, do you think it's possible to plug it in here?

@ericonr
Copy link
Member

ericonr commented Dec 1, 2020

CI is having weird issues :/

Also, please ping me when you have made the requested changes :)

@ghost
Copy link
Author

ghost commented Dec 2, 2020

@ericonr

$SOURCEFORGE_SITE is https://downloads.sourceforge.net/sourceforge. The subdomain downloads doesn't work is unresponsive but download does is. What should I do?

Copy link
Member

@ericonr ericonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If SOURCEFORGE_SITE generates too many failures, feel free to use the previous link.

Comment on lines 5 to 6
create_wrksrc=yes
hostmakedepends="unzip"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you add this? We use bsdtar for zip files.

And I believe it was working without create_wrksrc previously?

Comment on lines 15 to 17
vinstall ${wrksrc}/ro_RO.aff 644 /usr/share/hunspell
vinstall ${wrksrc}/ro_RO.dic 644 /usr/share/hunspell
vlicense ${wrksrc}/README
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure ${wrksrc} should be required here...

Also, use usr/share/hunspell.

@ghost
Copy link
Author

ghost commented Dec 2, 2020

@ericonr

Sourceforge keeps timing out, making the builds fail.

EDIT: Seems to work now.

@ericonr ericonr merged commit 8266f28 into void-linux:master Dec 2, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant