lurch: revert patch from #26757 #26843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The patch was erroneously applied after a github user claimed it to be a security issue, and later it was determined that this user was going around tricking various projects into applying their patch that had been exlicitly declined by upstream (xsf/xeps#894). There's probably a dialog to happen here around relative security of accepting unverified patches in the name of 'security' but this is neither the time nor the place.
Vaelatern
approved these changes
Nov 30, 2020
|
We should not maintain patches that change functionality, and that go against expressed upstream wishes. Approved. We have been known to accept security patches, referencing identical upstream commits or CVEs. We have been known to expedite upgrades when they include security fixes. Even if upstream chooses to be insecure by some measure, I think it is reasonable to let them. |
sgn
approved these changes
Nov 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch was erroneously applied after a github user claimed it to be
a security issue, and later it was determined that this user was going
around tricking various projects into applying their patch that had
been exlicitly declined by upstream (xsf/xeps#894).
There's probably a dialog to happen here around relative security of
accepting unverified patches in the name of 'security' but this is
neither the time nor the place.