Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rsync: fix IPv6 on musl #26937

Merged
merged 1 commit into from
Dec 4, 2020
Merged

rsync: fix IPv6 on musl #26937

merged 1 commit into from
Dec 4, 2020

Conversation

paper42
Copy link
Member

@paper42 paper42 commented Dec 4, 2020

close: #26796

ericonr
ericonr reviewed Dec 4, 2020
View reviewed changes
Copy link
Member

@ericonr ericonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that bug is 6 years old at this point :/

srcpkgs/rsync/template Outdated
checksum=becc3c504ceea499f4167a260040ccf4d9f2ef9499ad5683c179a697146ce50e

# Force enable IPv6 on musl - upstream bug https://bugzilla.samba.org/show_bug.cgi?id=10715
CFLAGS="$CFLAGS -DINET6"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can set CFLAGS="-DINET6" directly.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@pullmoll
Copy link
Member

pullmoll commented Dec 4, 2020

Ouch. I never actually tested whether rsync supports / uses IPv6 despite using it everywhere and all the time.

@paper42 paper42 force-pushed the 0001-rsync-fix-IPv6-on-musl.patch branch from 9f09910 to 3b3b5c7 Compare December 4, 2020 17:29
@ericonr
Copy link
Member

ericonr commented Dec 4, 2020

Thanks!

@ericonr ericonr merged commit fa9bc4a into void-linux:master Dec 4, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 10, 2021
@paper42 paper42 deleted the 0001-rsync-fix-IPv6-on-musl.patch branch April 8, 2022 11:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ericonr ericonr ericonr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rsync(musl version) not work over IPv6
3 participants
@paper42 @pullmoll @ericonr