New package: amule-0.0.20201210 #26999

hazayan · 2020-12-06T21:06:35Z

No description provided.

hazayan · 2020-12-06T22:40:14Z

Any pointers on the ircnotify check failure?

Duncaen · 2020-12-06T22:52:52Z

We generally don't allow untagged releases, fetching with git instead of tar balls and limiting the package to x86_64 or modifiying the root of the masterdir i.e. the symlink you are creating in do_build.
This should also use the gnu-configure build-style instead of using a single do_build.

The irc notification doesn't matter.

hazayan · 2020-12-06T23:16:36Z

We generally don't allow untagged releases, fetching with git instead of tar balls and limiting the package to x86_64 or modifiying the root of the masterdir i.e. the symlink you are creating in do_build.

The release is tagged. The git checkout actually points to a tag. It's just that it doesn't produce proper release tarballs.

Duncaen · 2020-12-06T23:25:38Z

Those tags come from converting svn to git, they are generated for every single commit, there are not 8 "releases" two months ago on a single day.

hazayan · 2020-12-06T23:28:20Z

Those tags come from converting svn to git, they are generated for every single commit, there are not 8 "releases" two months ago on a single day.

Well, what's the proper procedure then, if the upstream project lacks proper release ?

fosslinux · 2020-12-08T03:32:17Z

Ask upstream for releases.

Duncaen · 2020-12-08T11:44:10Z

srcpkgs/amule/template

+revision=1
+wrksrc=amule-master
+build_style=gnu-configure
+configure_args="--prefix=/usr --mandir=/usr/share/man


--prefix and --mandir are set by default for the gnu-configure build-style.

Please indent inside of variables with just one space instead of tab.

Duncaen · 2020-12-08T11:46:12Z

srcpkgs/amule/template

+	--enable-fileview --with-boost  --with-wx-config=/usr/bin/wx-config-gtk3"
+hostmakedepends="tar autoconf automake gettext gettext-devel wxWidgets-gtk3"
+makedepends="boost-devel zlib-devel wxWidgets-gtk3-devel gd-devel geoip-devel crypto++-devel"
+depends="wxWidgets-gtk3-devel gd-devel geoip-devel crypto++-devel"


Why does this depend on -devel packages, xbps-src will usually look at the resulting binaries and automatically add dependencies by looking at linked shared libraries.
If a dependency is not automatically detected you need to add them, but generally not the -devel ones.

https://github.com/void-linux/void-packages/pull/26999/checks?check_run_id=1514556177#step:10:1156

Duncaen · 2020-12-08T11:46:59Z

srcpkgs/amule/template

+	--enable-alcc --enable-webserver --disable-debug
+	--enable-optimize --enable-geoip --disable-upnp
+	--enable-fileview --with-boost  --with-wx-config=/usr/bin/wx-config-gtk3"
+hostmakedepends="tar autoconf automake gettext gettext-devel wxWidgets-gtk3"


Does it actually need tar (bsdtar is used by default to extract distfiles)?

Duncaen · 2020-12-08T11:47:50Z

srcpkgs/amule/template

+	vbin src/amule
+	vbin src/amuled
+	vbin src/amulecmd
+	vbin src/amulegui


Any reason to manually install the binaries instead of using the default make install target?

Duncaen · 2020-12-08T11:48:54Z

srcpkgs/amule/template

+maintainer="hazayan <hazayan@hotmail.com>"
+license="GPL-2.0-or-later"
+homepage="https://github.com/amule-project/amule"
+distfiles="https://github.com/amule-project/amule/archive/master.tar.gz"


master is wrong, if you really need to use unreleased tarballs, use a git revision/hash.
If you are using the master tarball, the checksum is going to break as soon as they add new
commits to master and we won't be able to rebuild the package without updating it.

Piraty · 2020-12-09T23:06:34Z

srcpkgs/amule/template

+maintainer="hazayan <hazayan@hotmail.com>"
+license="GPL-2.0-or-later"
+homepage="https://github.com/amule-project/amule"
+_commit="9fd038f8208f085dc7e0b52b73b2e18b6536437b"


put that below revision so it's near the meta data you'd change on an update (grep for _githash in the repo)

Piraty · 2020-12-09T23:11:34Z

srcpkgs/amule/template

+}
+
+do_install() {
+	make install DESTDIR="${DESTDIR}"


this is the default

Without that, the build fails because of empty destdir

Probably some other unrelated issue, removing do_install and using the default one should be exactly the same.

Duncaen · 2020-12-09T23:14:23Z

Also if you invent a version, use some thing like 0.0.20201210 so that in case there is a real release, the version is going to be greater.

Piraty · 2021-03-04T20:30:49Z

that branch needs a fix

closes void-linux#31434

Closes: void-linux#31440 [via git-merge-pr]

partially fixes void-linux#31343: some icon paths are still invalid. Also fix update for 1.5. Closes: void-linux#31439 [via git-merge-pr]

closes void-linux#14457

Piraty · 2021-06-14T20:00:11Z

@hazayan rebase your commit onto upstream/master

github-actions · 2022-05-01T02:14:23Z

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

hazayan force-pushed the amule branch from 8f9e72b to f45ede5 Compare December 8, 2020 01:21

Duncaen reviewed Dec 8, 2020

View reviewed changes

hazayan force-pushed the amule branch from f45ede5 to 67f252c Compare December 9, 2020 01:57

Piraty reviewed Dec 9, 2020

View reviewed changes

Piraty requested changes Dec 9, 2020

View reviewed changes

hazayan force-pushed the amule branch from 67f252c to b872e9f Compare December 9, 2020 23:42

hazayan changed the title ~~New package: amule-11066~~ New package: amule-0.0.20201210 Dec 9, 2020

hazayan force-pushed the amule branch from b872e9f to 6149804 Compare December 9, 2020 23:59

ericonr added the new-package This PR adds a new package label Dec 20, 2020

hazayan force-pushed the amule branch from 6149804 to 0c10493 Compare February 28, 2021 03:00

q66 and others added 8 commits June 12, 2021 17:17

diffutils: fix musl bootstrap under some conditions

64c5fba

m4: fix musl source bootstrap under some conditions

f568ae9

coreutils: fix musl source bootstrap under some conditions

2e99042

chroot-grep: fix musl bootstrap under some conditions

dde32b1

chroot-util-linux: explicitly disable readline

09fd344

opkg: update to 0.4.5.

7d5c37d

usbredir: update to 0.10.0

c37ae96

consul: update to 1.9.6.

02244f7

Johnnynator and others added 25 commits June 12, 2021 17:17

ark: update to 21.04.2.

dd8f2a9

elisa: update to 21.04.2.

2686bb1

kdeconnect: update to 21.04.2.

5a20008

kdegraphics-thumbnailers: update to 21.04.2.

3448913

knights: update to 21.04.2.

c4a33a9

kqtquickcharts: update to 21.04.2.

76f0336

libkdcraw5: update to 21.04.2.

d327791

gwenview: update to 21.04.2.

ea48b43

vlc: update to 3.0.15.

1422d1e

krita: update to 4.4.5.

be7f3d3

plasma-workspace: backport upstream patch to fix font management

4c8861b

closes void-linux#31434

MangoHud: update to 0.6.3.

7d1eea4

bullet: update to 3.17.

abf5b75

godot: rebuild against bullet-3.17

a24df51

openmw: rebuild against bullet-3.17

7b49d3a

efl: rebuild against bullet-3.17

08d0bac

vdrift: rebuild against bullet-3.17

54067f4

benchmark: update to 1.5.5.

f850d6f

jamulus: update to 3.8.0

2da6b2b

zsh-completions: update to 0.33.0.

b25cff0

Komikku: update to 0.29.2.

58b4bc3

Closes: void-linux#31440 [via git-merge-pr]

scribus: fix plugin loading, more function support

36387b3

partially fixes void-linux#31343: some icon paths are still invalid. Also fix update for 1.5. Closes: void-linux#31439 [via git-merge-pr]

xdg-utils: use bash in xdg-setttings

0d2b028

closes void-linux#14457

teams-bin: update to 1.4.00.13653.

2d68f0e

New package: amule-0.0.20201210

e1b2a8a

hazayan force-pushed the amule branch from 0c10493 to e1b2a8a Compare June 12, 2021 21:22

github-actions bot added the Stale label May 1, 2022

github-actions bot closed this May 16, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New package: amule-0.0.20201210 #26999

New package: amule-0.0.20201210 #26999

hazayan commented Dec 6, 2020

hazayan commented Dec 6, 2020

Duncaen commented Dec 6, 2020

hazayan commented Dec 6, 2020 •

edited

Duncaen commented Dec 6, 2020

hazayan commented Dec 6, 2020

fosslinux commented Dec 8, 2020

Duncaen Dec 8, 2020

hazayan Dec 9, 2020

Duncaen Dec 8, 2020

hazayan Dec 9, 2020

Duncaen Dec 8, 2020

Duncaen Dec 8, 2020

Duncaen Dec 8, 2020

Piraty Dec 9, 2020

hazayan Dec 9, 2020

Piraty Dec 9, 2020

hazayan Dec 9, 2020

Duncaen Dec 9, 2020

hazayan Dec 9, 2020

Duncaen commented Dec 9, 2020

Piraty commented Mar 4, 2021

Piraty commented Jun 14, 2021

github-actions bot commented May 1, 2022

New package: amule-0.0.20201210 #26999

New package: amule-0.0.20201210 #26999

Conversation

hazayan commented Dec 6, 2020

hazayan commented Dec 6, 2020

Duncaen commented Dec 6, 2020

hazayan commented Dec 6, 2020 • edited

Duncaen commented Dec 6, 2020

hazayan commented Dec 6, 2020

fosslinux commented Dec 8, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Duncaen commented Dec 9, 2020

Piraty commented Mar 4, 2021

Piraty commented Jun 14, 2021

github-actions bot commented May 1, 2022

hazayan commented Dec 6, 2020 •

edited