Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some gnu-makefile build style users #27005

Merged
merged 2 commits into from
Jan 27, 2021
Merged

Fix some gnu-makefile build style users #27005

merged 2 commits into from
Jan 27, 2021

Conversation

ericonr
Copy link
Member

@ericonr ericonr commented Dec 6, 2020

Mainly depends on the change from #27003 for CXXFLAGS inclusion.

@ericonr ericonr force-pushed the makefile branch 2 times, most recently from 1ab3bfc to e89495d Compare December 11, 2020 02:07
@ericonr
Copy link
Member Author

ericonr commented Dec 11, 2020

crypto++ only fails on glibc :/

@ericonr ericonr force-pushed the makefile branch 2 times, most recently from 3cee62f to dfdbbd8 Compare January 25, 2021 19:25
@ericonr
fuse-zip: remove CXXFLAGS workaround.
3da35e5 
No longer necessary.

Also fix distfile location, for some reason the 0.7.1 tarball had been
removed from downloads.
@ericonr
splix: remove unnecessary build_style.
8d55fef 
Also xlint.
@ericonr
Copy link
Member Author

ericonr commented Jan 25, 2021

@mvf @thypon ok with changes?

@mvf
Copy link
Contributor

mvf commented Jan 25, 2021

Looks good, thanks @ericonr!

Something else to consider with gnu-makefile: Maybe do_build should also pass PREFIX=/usr. Some Makefiles compile in PREFIX-based paths, so not having it during do_build can cause subtly broken binaries. This has bitten me in the past with spectrwm (ae50942) and it seems there are gnu-makefile templates that set make_build_args only for PREFIX.

@ericonr
Copy link
Member Author

ericonr commented Jan 25, 2021

@mvf I've thought the same thing, but haven't tried to actually fix it. We could probably remove make_build_args from many templates and avoid weird surprises. I don't know of any objections against it, but I also don't know if it isn't passed because no one had the idea / implemented It or for some specific reason.

@ericonr ericonr merged commit 9499c44 into void-linux:master Jan 27, 2021
@ericonr ericonr deleted the makefile branch January 27, 2021 18:58
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ericonr @mvf